Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358328

Summary: NPE after right clicking on a project and selecting properties -> EGL Build Path
Product: z_Archived Reporter: Thomas Wu <wxwu>
Component: EDTAssignee: Song Fan <songfan>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P3 CC: chenzhh, smythew, svihovec, xiaobinc
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Select All button error
none
Deselect All button error
none
fix patch lasher: iplog+

Description Thomas Wu CLA 2011-09-20 22:47:16 EDT
Build Identifier: 20110919

Select All button will not be enabled until user select some items in Projects list. Deselect All button should NOT be enabled before user select anyone.

Reproducible: Always

Steps to Reproduce:
1. New an EGL project by default steps.
2. Try to new another EGL project.
3. In the New EGL Project page, input a Project name, and click Next button. 
4. In the Proeject Templates page, select Web Client Project or Web Client With
Services Project, then click Next button.
5. In the RUI Widgets Libraries selecting page, click Next button directly.
Actual results: In the EGL build Settings defining page, the Select All button is disabled now. But there are some projects alreay listing in projects view, the Select All button should be enabled to let user click. In addition, if I click any project in the projects list but not select anyone, both Select All and Deselect All button will be enabled. At this time, the Deselect All button should not be enable because I have not select any project here.
Comment 1 Thomas Wu CLA 2011-09-20 22:50:36 EDT
Created attachment 203723 [details]
Select All button error
Comment 2 Thomas Wu CLA 2011-09-20 22:51:16 EDT
Created attachment 203724 [details]
Deselect All button error
Comment 3 Tony Chen CLA 2011-09-23 06:17:14 EDT
This is a minor issue, re-set the severity
Comment 4 Will Smythe CLA 2011-12-16 11:55:27 EST
The real issue I see here is that the 2 pages (RUI Widget Library and EGL Build Path) are not in sync. For example, if you already have the RUI and Dojo widget projects in your workspace and have selected both in the RUI Widget Library page, they should be selected in the EGL Build Path page. Bottom line: the two wizard pages should be in sync and reflecting the correct selections.
Comment 5 Xiao Bin Chen CLA 2011-12-19 02:22:32 EST
Fixed the problem Will mentioned.
Comment 6 Brian Svihovec CLA 2012-01-12 10:52:12 EST
In the latest EDT build, right click on a project and select properties -> EGL Build Path.

I get the following message: The currently displayed page contains invalid values.

The following exception is in the log:

java.lang.NullPointerException
at org.eclipse.edt.ide.ui.internal.wizards.buildpaths.ProjectsWorkbookPage.updateProjectsList(ProjectsWorkbookPage.java:141)
at org.eclipse.edt.ide.ui.internal.wizards.buildpaths.ProjectsWorkbookPage.init(ProjectsWorkbookPage.java:101)
at org.eclipse.edt.ide.ui.internal.property.pages.EGLProjectBuildPathPropertyPage.initFields(EGLProjectBuildPathPropertyPage.java:380)
at org.eclipse.edt.ide.ui.internal.property.pages.EGLProjectBuildPathPropertyPage.createContents(EGLProjectBuildPathPropertyPage.java:109)
at org.eclipse.jface.preference.PreferencePage.createControl(PreferencePage.java:232)
at org.eclipse.jface.preference.PreferenceDialog.createPageControl(PreferenceDialog.java:1501)
at org.eclipse.jface.preference.PreferenceDialog$14.run(PreferenceDialog.java:1258)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:49)
at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
at org.eclipse.jface.preference.PreferenceDialog.showPage(PreferenceDialog.java:1252)
at org.eclipse.ui.internal.dialogs.FilteredPreferenceDialog.showPage(FilteredPreferenceDialog.java:674)
at org.eclipse.jface.preference.PreferenceDialog$10.run(PreferenceDialog.java:708)
at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
at org.eclipse.jface.preference.PreferenceDialog$9.selectionChanged(PreferenceDialog.java:704)
at org.eclipse.jface.viewers.StructuredViewer$3.run(StructuredViewer.java:867)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:49)
at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
at org.eclipse.jface.viewers.StructuredViewer.firePostSelectionChanged(StructuredViewer.java:865)
at org.eclipse.jface.viewers.StructuredViewer.handlePostSelect(StructuredViewer.java:1205)
at org.eclipse.jface.viewers.StructuredViewer$5.widgetSelected(StructuredViewer.java:1230)
at org.eclipse.jface.util.OpenStrategy.firePostSelectionEvent(OpenStrategy.java:251)
at org.eclipse.jface.util.OpenStrategy.access$5(OpenStrategy.java:245)
at org.eclipse.jface.util.OpenStrategy$3.run(OpenStrategy.java:419)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4041)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3660)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
at org.eclipse.jface.window.Window.open(Window.java:801)
at org.eclipse.ui.dialogs.PropertyDialogAction.run(PropertyDialogAction.java:157)
at org.eclipse.jface.action.Action.runWithEvent(Action.java:498)
at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4066)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3657)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2640)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2604)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2438)
at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:671)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:664)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:620)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:575)
at org.eclipse.equinox.launcher.Main.run(Main.java:1408)
Comment 7 Xiao Bin Chen CLA 2012-01-12 20:54:52 EST
fan is the owner of wizard. give it to him.
Comment 8 Song Fan CLA 2012-01-15 20:40:02 EST
Created attachment 209511 [details]
fix patch

In project properties window, the variable fSelectedImportProjectList is null so that a NPE is thrown. fSelectedImportProjectList is only used while creating a new project, so check if it is null before using it when set the project list.
Comment 9 Song Fan CLA 2012-01-16 05:12:11 EST
fixed
Comment 10 Thomas Wu CLA 2012-01-18 09:57:22 EST
Verified in build 20120117
Comment 11 Brian Svihovec CLA 2012-01-19 14:42:08 EST
*** Bug 367785 has been marked as a duplicate of this bug. ***