Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358286

Summary: EGL project wizard's base package looks like a read only (disabled) field
Product: z_Archived Reporter: Jing Qian <jqian>
Component: EDTAssignee: Song Fan <songfan>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: broy2, chenzhh, hjiyong, smythew, tdramsey
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Fix patch lasher: iplog+

Description Jing Qian CLA 2011-09-20 14:39:39 EDT
With 20110920's build,

the new egl project wizard's base package field has a greyed package name 
org.mycompany.myapp

the color is grey, which makes the whole text field appeared to be greyed out or read only field. 

and since there is value there, after I created project, I expected to see a package called org.mycompany.myapp, but I don't see it, it's even more confusing.
Comment 1 Huang Ji Yong CLA 2011-09-29 07:42:15 EDT
I don't think this is a bug.
This is a default place holder. Theresa suggest to add the place holder by default.
Comment 2 Theresa Ramsey CLA 2011-09-29 10:23:53 EDT
I thought we planned to move the base package field to a later page in the wizard, and include it only for RUI apps.  

The field shouldn't be greyed out, since that suggests that the user can't modify the default provided.
Comment 3 Jing Qian CLA 2011-10-03 10:52:38 EDT
Thanks, Theresa.

The defect is reporting that the filed should not be greyed out, as it is misleading to the end user.
Comment 4 Huang Ji Yong CLA 2011-10-10 04:16:08 EDT
(In reply to comment #3)
> Thanks, Theresa.
> 
> The defect is reporting that the filed should not be greyed out, as it is
> misleading to the end user.

Hi Jing & Theresa,

The greyed style is the default style of the text field's placeholder(hint), we cannot change that.
The hint is only there to help user understand how to fill in the field. If the greyed hint is not accepted, I guess we can just leave the field blank or have a default value in it.
How do you think?
Comment 5 Jing Qian CLA 2011-10-10 09:29:48 EDT
It should not be greyed, like we said, it's very confusing to end user.

If you want to show an example, see the egldd file's creating new resource binding, it has another label below the text field to show some example on what it should be. 

As far as what should be the default package when it creates project, 
Will or Theresa might have an opinion.
bottom line is it should create package with whatever you have in the text fields. or not creating a package if the text field is empty.
Comment 6 Theresa Ramsey CLA 2011-10-12 14:43:38 EDT
Hi Jing,
The field is not greyed out. Placeholder text (an example in the field used when space is limited) is grey...this is standard for Eclipse, Dojo, IBM One UI, etc.  The placeholder text disappears when the user clicks within the field.
Comment 7 Theresa Ramsey CLA 2011-10-12 14:56:33 EDT
That being said, since this panel has room we could put the example below the field instead of as placeholder / hint text within the field. This style is useful since the hint text doesn't disappear like the text within the field.

Base package:  [           ]
Example:  com.mycompany.myapp


It seems to take the placeholder text doesn't seem to always appear for me,  which is odd. If I hit Next and Back then it's there.  Anyone else see this?
Comment 8 Will Smythe CLA 2011-10-12 15:03:22 EDT
This is a nit, but: the Base Package label and text field (which were moved from the first page of the New project wizard) are not quite aligned with the Library table. If GridLayout is being used for this label and field, probably need to set the marginWidth to 0.

Mentioning this here since I assume some UI change will be made to the wizard page as part of this bug.
Comment 9 Song Fan CLA 2011-10-25 04:32:10 EDT
Created attachment 205889 [details]
Fix patch

fix margin issue
Add a label to show the example instead of showing the example in text widget
Comment 10 Huang Ji Yong CLA 2011-10-28 05:41:31 EDT
Code Committed
Comment 11 Song Fan CLA 2011-10-30 22:41:41 EDT
fixed
Comment 12 Jing Qian CLA 2011-11-11 12:43:57 EST
Using 2011/11/11/0901's build

I no longer see a base package in the project wizard for any types of EGL project, has this been removed intentionally?
Comment 13 Jing Qian CLA 2011-11-14 11:05:20 EST
seems this is intentional based on bug# 357800 comment#9 by Will