Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358280

Summary:	"Remove Repository from View" dialog proceeds on Esc
Product:	[Technology] EGit	Reporter:	Markus Keller <markus.kell.r>
Component:	UI	Assignee:	Kevin Sawicki <kevin>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	matthias.sohn
Version:	1.1
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Markus Keller

2011-09-20 13:47:39 EDT

1.1.0.201109151100

In the Git Repositories view, the "Remove Repository from View" command shows a "Confirm Project Deletion" MessageDialog if the workspace contains shared projects from that repository.

When I press Esc or click the close box in this dialog, the repository is removed. Esc should always mean "Cancel".

Implementation detail: MessageDialog#open() returns SWT.DEFAULT if none of the buttons has been pressed. This has always been like this, but the Javadoc only tells it explicitly since 3.5.

Comment 1 Kevin Sawicki

2011-09-20 16:30:22 EDT

Proposed fix pushed to: http://egit.eclipse.org/r/#change,4274

Comment 2 Matthias Sohn

2011-09-22 04:14:25 EDT

merged as fd140918c8ff9d59cfebea1eb21498ec7f6f4606