| Summary: | GitQuickDiffProvider.isEnabled() not correctly implemented - breaks Quick Diff | ||
|---|---|---|---|
| Product: | [Technology] EGit | Reporter: | Dani Megert <daniel_megert> |
| Component: | UI | Assignee: | Project Inbox <egit.ui-inbox> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P3 | CC: | matthias.sohn, remy.suen |
| Version: | 1.1 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
A change set has been pushed to Gerrit for review. http://egit.eclipse.org/r/#change,4275 merged as 5f94ddcb333be6c3be1ee56aee5c105cdb744c25 Verified in 1.2.0.201110021920. |
1.1.0.201109151100-r. GitQuickDiffProvider.isEnabled() must not return 'true' for files coming from a project that isn't shared with Git. Quick Diff tries to find an alternative to the default Quick Diff provider if a provider can't handle a certain case (mostly because the file is not shared with the corresponding team provider). Test Case: 1. set Git as reference provider ('Quick Diff' preference page) 2. create a local project and add a file 3. open the file and start typing ==> changes are not shown in ruler.