Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358245

Summary: GitQuickDiffProvider.isEnabled() not correctly implemented - breaks Quick Diff
Product: [Technology] EGit Reporter: Dani Megert <daniel_megert>
Component: UIAssignee: Project Inbox <egit.ui-inbox>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: matthias.sohn, remy.suen
Version: 1.1   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Dani Megert CLA 2011-09-20 09:43:00 EDT
1.1.0.201109151100-r.

GitQuickDiffProvider.isEnabled() must not return 'true' for files coming from a project that isn't shared with Git.

Quick Diff tries to find an alternative to the default Quick Diff provider if a provider can't handle a certain case (mostly because the file is not shared with the corresponding team provider).

Test Case:
1. set Git as reference provider ('Quick Diff' preference page)
2. create a local project and add a file
3. open the file and start typing
==> changes are not shown in ruler.
Comment 1 Remy Suen CLA 2011-09-20 18:01:30 EDT
A change set has been pushed to Gerrit for review.
http://egit.eclipse.org/r/#change,4275
Comment 2 Matthias Sohn CLA 2011-09-22 04:27:00 EDT
merged as 5f94ddcb333be6c3be1ee56aee5c105cdb744c25
Comment 3 Dani Megert CLA 2011-10-04 04:24:43 EDT
Verified in 1.2.0.201110021920.