Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358192

Summary:	tycho-extras integration test fails without -Dtycho.testSettings
Product:	z_Archived	Reporter:	Tobias Oberlies <t-oberlies>
Component:	Tycho	Assignee:	Tobias Oberlies <t-oberlies>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	P3
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Tobias Oberlies

2011-09-20 04:02:56 EDT

The system property tycho.testSettings was meant to be optional mean to set the settings.xml for integration tests. However currently there is an NPE if the property is not set:

testLocalMavenRepository(org.eclipse.tycho.test.TYCHO406testArgLineConfiguration.TestArgLineConfigurationTest) 
  Time elapsed: 0.006 sec  <<< ERROR!
java.lang.NullPointerException
	at 
org.eclipse.tycho.test.util.EnvironmentUtil.getTestSettings(EnvironmentUtil.java:84)
	at 
org.eclipse.tycho.test.AbstractTychoIntegrationTest.getSettings(AbstractTychoIntegrationTest.java:114)
	at 
org.eclipse.tycho.test.AbstractTychoIntegrationTest.getVerifier(AbstractTychoIntegrationTest.java:51)
	at 
org.eclipse.tycho.test.TYCHO406testArgLineConfiguration.TestArgLineConfigurationTest.testLocalMavenRepository(TestArgLineConfigurationTest.java:28)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
	at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
	at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
	at 
org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79)
	at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71)
	at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
	at 
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
	at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:119)
	at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:101)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at 
org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103)
	at $Proxy0.invoke(Unknown Source)
	at 
org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:150)
	at 
org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:91)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69)

Comment 1 Tobias Oberlies

2011-09-20 09:06:38 EDT

Fixed in master in tycho-extras (so if re-staging of 0.13.0 should be necessary due to other reasons, this fix could be included). Also added null-check in tycho 0.14.0 in EnvironmentUtil.