Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358156

Summary:	Multiple next/previous buttons appear in compare viewer
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	trivial
Priority:	P3
Version:	0.2
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2011-09-19 15:43:18 EDT

1. Go to git-log page, find a commit, click it 
2. In the right-hand pane, click the <-> icon beside one of the files
3. Compare editor opens
4. Change the URL after the hash sign so it references a different commit in which the same file has changed.
5. The viewer updates correctly, but it adds a second set of Next/Previous Diff buttons when it does so. Every time you point the viewer at a new commit, 2 more buttons are added.

Here are 2 URLs you can use to simulate this. Load the first url, then load the second url to see the problem.
 i.  http://localhost:8080/compare/compare.html?readonly#/gitapi/diff/18abcc4ef845e412140821195755da3748d90564..89af34e9bd539fc8babe2aac0f08d9cadb904937/file/ac/bundles/org.eclipse.orion.client.editor/web/orion/editor/contentAssist.js

ii. http://localhost:8080/compare/compare.html?readonly#/gitapi/diff/5295f1bca5a61315bf495ceb1f23336472fc4f5e..18abcc4ef845e412140821195755da3748d90564/file/ac/bundles/org.eclipse.orion.client.editor/web/orion/editor/contentAssist.js

Comment 1 libing wang

2011-09-26 15:25:42 EDT

this has been fixed.

Comment 2 libing wang

2011-09-26 15:26:59 EDT

I thought it was the search result page.Reopened.

Comment 3 John Arthorne

2015-05-05 14:54:51 EDT

Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html