Bug 358147

Description Junwei Sun 2011-09-19 13:54:47 EDT

Build Identifier: 7.4.5.v20110725

jetty client socket fd leak when access an URL with bad domain

I'm using jetty client(jetty-client-7.4.5.v20110725)as http client to
download html pages, but find that jetty client has socket fd leak
issue.
When jetty client download a URL which domain can not be resolved, it
will leak a socket fd, such as URL "http://com.br/".
It will throw an UnresolvedAddressException:

[05 Sep 2011 11:10:55] [main] [Slf4jLog.java:80] [DEBUG] EXCEPTION 
java.nio.channels.UnresolvedAddressException
        at sun.nio.ch.Net.checkAddress(Net.java:30)
        at sun.nio.ch.SocketChannelImpl.connect(SocketChannelImpl.java:487)
        at
org.eclipse.jetty.client.SelectConnector.startConnection(SelectConnector.java:99)
        at
org.eclipse.jetty.client.HttpDestination.startNewConnection(HttpDestination.java:265)
        at
org.eclipse.jetty.client.HttpDestination.doSend(HttpDestination.java:552)
        at
org.eclipse.jetty.client.HttpDestination.send(HttpDestination.java:490)
        at org.eclipse.jetty.client.HttpClient.send(HttpClient.java:178)
        at cn.vobile.colander.Crawler.Crawler.addCrawlRequest(Crawler.java:138)
        at cn.vobile.colander.Crawler.Crawler.main(Crawler.java:438)
[05 Sep 2011 11:10:56] [main] [Slf4jLog.java:50] [WARN] CONNECTION
FAILED CrawlExchange@1309073=GET//com.br:80/#9

Then, a socket fd leaked, just like the following fd:

$ lsof -p 4499|grep sock
java    4499 sunjw   41r  sock        0,6      0t0  151513 can't
identify protocol
java    4499 sunjw   42r  unix 0xf4ffc700      0t0  151855 socket
java    4499 sunjw   43r  sock        0,6      0t0  151515 can't
identify protocol

Is there any method of http client to close these socket(s)?

I understand jetty client has feature to manage connection pool. 
However, in this case, the URL is a bad URL which domain does not exist.
So, there is no connection for this URL at all actually. But the socket fd leaves there, never disappears!
Even I set the idle timeout to be very small, the socket fd is still there.
When I submit more of such URLs' requests, socket fd number increases
more and more. At last, the program dies.
So from my point of view, this issue should be a bug in jetty client code.

The reproducing code is: 

             HttpClient hc = new HttpClient();
             hc.setConnectorType(HttpClient.CONNECTOR_SELECT_CHANNEL);
             hc.setMaxConnectionsPerAddress(1);
             hc.setConnectBlocking(false);
             hc.setIdleTimeout(10 * 1000L);
             hc.setThreadPool(new QueuedThreadPool(3));
             hc.setTimeout(60000);
             hc.start();
             ContentExchange ce = new ContentExchange();
             ce.setURL("http://com.br");
             hc.send(ce);
             log.info("sended, waitForDone");
             ce.waitForDone();
             log.info("done, sleeping");
             Thread.sleep(100*1000L);

Thanks.

-- 
Best Regards,
Junwei

Reproducible: Always

Steps to Reproduce:
1. execute above code.
2. use lsof to probe how many socket fd the program uses.