Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358108

Summary: [ds] Implement new functionality for R4.3 compendium (RFC 176)
Product: [Eclipse Project] Equinox Reporter: Thomas Watson <tjwatson>
Component: CompendiumAssignee: Stoyan Boshev <s.boshev>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: hargrave, jwross, s.boshev, sja.eclipse
Version: 3.8.0 JunoKeywords: plan
Target Milestone: Juno M5   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Bug Depends on: 358109, 358110, 366582    
Bug Blocks: 366585    
Attachments:
Description Flags
Proposed patch none

Description Thomas Watson CLA 2011-09-19 08:46:41 EDT
RFC 176 has a number of small enhancements which need to be implemented by DS.
Comment 1 Thomas Watson CLA 2011-09-19 08:55:32 EDT
This is a plan item for Juno.  Bug 358109 and bug 358110 describe the new functionality being added by RFC 176.
Comment 2 John Ross CLA 2011-11-01 14:28:16 EDT
Note that the exported version of org.osgi.service.component has been bumped up to 1.2 for the r4.3 compendium release. So the imported version range, currently "[1.1.0,1.2.0)", will need to be updated as well.
Comment 3 Stoyan Boshev CLA 2011-12-16 11:44:18 EST
Created attachment 208493 [details]
Proposed patch
Comment 4 Stoyan Boshev CLA 2012-01-04 11:10:55 EST
BJ, would you like to review the patch before releasing it?
Comment 5 BJ Hargrave CLA 2012-01-04 11:35:41 EST
(In reply to comment #4)
> BJ, would you like to review the patch before releasing it?

It is a pretty big patch and I am not at all familiar with the code base, so I can't really provide a meaningful code review. Sorry.

I will note that I did not see the manifest change to update the component package import version per comment 2.

Finally, I would like very much for this DS impl to include the component package and also export (as well as import) it. This will make the impl more "stand-alone" and not require some other bundle to export the component package.
Comment 6 Stoyan Boshev CLA 2012-01-05 11:28:17 EST
(In reply to comment #5)
> 
> I will note that I did not see the manifest change to update the component
> package import version per comment 2.

This is already done in HEAD.
> 
> Finally, I would like very much for this DS impl to include the component
> package and also export (as well as import) it. This will make the impl more
> "stand-alone" and not require some other bundle to export the component
> package.
This is subject to another topic. Could you open another bug for that? 
BTW are there other equinox bundles implementing compendium services that have this in place?
The DS bundle depends on the org.eclipse.equinox.util bundle. If ds needs to be installed on other OSGi FW than Equinox, then it would need also the org.eclipse.equinox.supplement bundle. So, at this stage it does not seem to be much "stand-alone".
Comment 7 John Ross CLA 2012-01-05 12:23:57 EST
(In reply to comment #6)
> > Finally, I would like very much for this DS impl to include the component
> > package and also export (as well as import) it. This will make the impl more
> > "stand-alone" and not require some other bundle to export the component
> > package.
> BTW are there other equinox bundles implementing compendium services that have
> this in place?

The coordinator implementation does this, for one.
Comment 8 Thomas Watson CLA 2012-01-05 13:52:12 EST
(In reply to comment #6)
> (In reply to comment #5)
> > 
> > I will note that I did not see the manifest change to update the component
> > package import version per comment 2.
> 
> This is already done in HEAD.
> > 
> > Finally, I would like very much for this DS impl to include the component
> > package and also export (as well as import) it. This will make the impl more
> > "stand-alone" and not require some other bundle to export the component
> > package.
> This is subject to another topic. Could you open another bug for that? 

There is already another bug for this and I agree it is not related to this bug.
Comment 9 Stoyan Boshev CLA 2012-01-10 08:41:37 EST
The patch is released in master