Bugzilla – Full Text Bug Listing
| Summary: | Generation arguments aren't passed along to generators | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Matt Heitz <mheitz> |
| Component: | EDT | Assignee: | Justin Spadea <jspadea> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | greer, jeffdouglas |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
|
Description
Matt Heitz
Fixed the following: ExampleGenerator JavaScriptDevGenerator JavaGenerator JavaScriptGenerator AbstractGenerator WorkingCopyGenerationOperation I removed some duplicate methods that did identical things (one method took IFile, the other took IResource, the IFile version is now gone). Each generator had a buildArgs() which was doing the same thing. This has been moved to AbstractGenerator, and this method now reads in the argument string specified on the property dialog and breaks the string into an argument array. This uses the same type of escaping and quoting that the Java command line uses to break up arguments. Note that I tried to test this with "-report true", but this flag is being checked before the arguments get processed. Someone needs to change how this flag is used. I did step through the code to verify that, after the args are processed, that the report parameter was set to true. It's working. I updated JavaGenerator so it doesn't look at the -report flag until it's time to generate something. By that time the args have been processed, so we get the correct value for -report. Did you make the same change in the JavaScript generator? No, I didn't update the JS generator. Adding Scott to the CC list so he can look into it. |