Bugzilla – Full Text Bug Listing
| Summary: | Remove 'Enable Animations' from user interface | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Dani Megert <daniel_megert> |
| Component: | UI | Assignee: | Lars Vogel <Lars.Vogel> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | akurtakov, daniel_megert, Lars.Vogel, remy.suen |
| Version: | 4.2 | Flags: | Lars.Vogel:
pmc_approved+
|
| Target Milestone: | 4.17 RC1 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| See Also: |
https://git.eclipse.org/r/162614 https://git.eclipse.org/r/163124 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=08b49415195bba4bc62a2447710de294d63dd44d https://git.eclipse.org/r/163235 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0f720a7a91752c8acb93855af5665b6081e895ed |
||
| Whiteboard: | |||
| Bug Depends on: | 357939 | ||
| Bug Blocks: | 563471 | ||
|
Description
Dani Megert
(In reply to comment #0) > There is no need for the 'Enable Animations' preference on Windows 7 (and maybe > other OSes), as there is an OS setting which should be honored. Dani, that option is also there in 3.x (in the same 'Appearance' preference page). Do you think we should strip it out from there too? (In reply to comment #1) > (In reply to comment #0) > > There is no need for the 'Enable Animations' preference on Windows 7 (and maybe > > other OSes), as there is an OS setting which should be honored. > > Dani, that option is also there in 3.x (in the same 'Appearance' preference > page). Do you think we should strip it out from there too? +1. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. If the bug is still relevant, please remove the "stalebug" whiteboard tag. I agree we should remove the preference and related code. Currently it is only used for maximize and unzoom (see AnimationEngine) and makes the UI jaggy. See also Bug 357939, where the feedback was not positive after implementing it and enabling it by default. New Gerrit change created: https://git.eclipse.org/r/162614 Dani, Alex, I suggest to remove this bad-performing setting and its support from platform. Please approve or reject. I honestly have no idea what is this enabling as I haven't found any visual difference from enabling it. (In reply to Alexander Kurtakov from comment #8) > I honestly have no idea what is this enabling as I haven't found any visual > difference from enabling it. If you maximize or and editor the window, you should see a difference. (In reply to Alexander Kurtakov from comment #8) > I honestly have no idea what is this enabling as I haven't found any visual > difference from enabling it. So no objections against removing it? Not from me. It would be nice if whatever code is responsible for handling this preference change is removed too. (In reply to Alexander Kurtakov from comment #11) > Not from me. It would be nice if whatever code is responsible for handling > this preference change is removed too. +1 New Gerrit change created: https://git.eclipse.org/r/163124 Gerrit change https://git.eclipse.org/r/163124 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=08b49415195bba4bc62a2447710de294d63dd44d New Gerrit change created: https://git.eclipse.org/r/163235 Gerrit change https://git.eclipse.org/r/163235 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0f720a7a91752c8acb93855af5665b6081e895ed Removed from UI, remaining code will be removed in 4.17 |