Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357896

Summary:	promote script does not fail when p2 operations fail
Product:	[WebTools] WTP Releng	Reporter:	David Williams <david_williams>
Component:	releng	Assignee:	webtools.releng <webtools.releng-inbox>
Status:	RESOLVED WONTFIX	QA Contact:	Carl Anderson <ccc>
Severity:	major
Priority:	P3
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description David Williams

2011-09-15 20:27:48 EDT

+++ This bug was initially created as a clone of Bug #357056 +++

In bug 357056 we discovered that improper file permission could cause some p2 related parts of the promote script to fail, since they could not update artifacts.jar, but the script itself would not fail. This isn't good, since causes the error to go unnoticed. 

So, while the permissions problem has been corrected, I wanted to track the need to investigate if script could be made more bullet proof.

Comment 1 David Williams

2011-09-17 22:37:15 EDT

I'm going to close as "won't fix". I did investigate, and it appears there is no way to get or capture an error from the p2.process.artifacts. 

At least from my reading of help document: 

http://help.eclipse.org/indigo/index.jsp?topic=/org.eclipse.platform.doc.isv/guide/p2_repositorytasks.htm

So, I think that just leave close viewing of log file to see if error messages (or, suppose someone could write a script, to capture the log, and then automatically check the log, if they wanted ... but seems probably not worth it). 

Tip: I think using the -v (verbose) flag in promote script can make it _harder_ to spot errors. The "verbose" part is primarily a list of the hundreds of files copied ... so, each to miss the line or two that has an interesting message in it.