Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357875

Summary: Saving a perspective with a minimized part stack leaves it behind when closed
Product: [Eclipse Project] Platform Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Dean Roberts <dean.t.roberts>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: dean.t.roberts, emoffatt, remy.suen
Version: 4.2   
Target Milestone: 4.2 M3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch to adjust TrimStack ids when perspective id changes
none
Fix warnings in MinMaxAddon.java none

Description Remy Suen CLA 2011-09-15 16:12:05 EDT 
I20110914-0200

1. Minimize a part stack.
2. Save the perspective.
3. Open another perspective.
4. The previously minimized part stack is still in the trim stack.
Comment 1 Dean Roberts CLA 2011-09-16 09:15:13 EDT 
Also, the saved perspective looses the TrimStack
Comment 2 Dean Roberts CLA 2011-09-22 08:37:36 EDT 
Created attachment 203837 [details]
Patch to adjust TrimStack ids when perspective id changes
Comment 3 Dean Roberts CLA 2011-09-22 09:27:07 EDT 
Created attachment 203840 [details]
Fix warnings in MinMaxAddon.java

Here is a patch that fixes the warnings (that where pre existing) in MinMaxAddon.java.

This patch should be applied after the 1st patch on this defect, which actually fixes the problem.

I would suggest that these patches be done in two commits so that we can clearly see the fix code.

Unfortunately, on of the files needed to fix MinMaxAddOn itself has warnings ... but I don't have enough information yet to fix it :-)  Email sent about that one.
Comment 4 Eric Moffatt CLA 2011-09-23 11:32:16 EDT 
Pushed in >20110923.

commit 092854683ee2e043949f8e72717872cb4610aaeb

Dean, I changed the listener code to only modify trim in the window containing the perspective whose id changed rather than all windows...when we do a 'save as' the only window affected should be the one we're in.
Comment 5 Eric Moffatt CLA 2011-09-23 11:40:00 EDT 
Rather than applying the warnings patch I've opened a separate defect (bug 358739) to track a solution that will fix our dependency on workbench rather than getting 'friendly'...

Nice work, thanks!
Comment 6 Eric Moffatt CLA 2011-10-26 13:44:08 EDT 
Verified in I20111025-2000.