Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357846

Summary: FacetProjectCreationDataModelProvider creates listeners that are not cleaned up in the dispose method
Product: [WebTools] WTP Common Tools Reporter: Roberto Sanchez Herrera <shr31223>
Component: wst.commonAssignee: Roberto Sanchez Herrera <shr31223>
Status: RESOLVED FIXED QA Contact: Carl Anderson <ccc>
Severity: normal    
Priority: P3 Flags: ccc: review+
Version: 3.2.4   
Target Milestone: 3.3.2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 357558    
Bug Blocks: 360039    
Attachments:
Description Flags
Proposed patch for 3.3.2 and 3.4 none

Description Roberto Sanchez Herrera CLA 2011-09-15 13:32:23 EDT 
+++ This bug was initially created as a clone of Bug #357558 +++

The class org.eclipse.wst.common.componentcore.datamodel.FacetProjectCreationDataModelProvider creates listeners (IFacetedProjectListener and IDataModelListener) that are not cleaned up in the dispose method. This can cause problem in case other classes are using the data model after the provider is disposed. In fact, the provider should not act on the model if it has been already disposed.
Comment 1 Roberto Sanchez Herrera CLA 2011-09-15 13:37:53 EDT 
This bug is to commit code to WTP 3.3.2 and 3.4.0
Comment 2 Roberto Sanchez Herrera CLA 2011-10-10 16:00:58 EDT 
Created attachment 204901 [details]
Proposed patch for 3.3.2 and 3.4

This is the proposed patch. I used R3_3_maintenance (for 3.3.2) to create it, but I verified it can be applied to HEAD (for 3.4)as well.
Comment 3 Roberto Sanchez Herrera CLA 2011-10-10 16:44:23 EDT 
Code committed to R3_3_maintenance and HEAD