Bugzilla – Full Text Bug Listing
| Summary: | Eclipse forms cannot have a "single message" | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Laurent Goubet <laurent.goubet> |
| Component: | User Assistance | Assignee: | platform-ua-inbox <platform-ua-inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | ben.cox, dejan, remy.suen |
| Version: | 3.8 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | stalebug | ||
Note that this only seems to apply if we try and attach the prefix to one of the forms' controls. Remy : hummm, the component for Eclipse forms (http://www.eclipse.org/articles/Article-Forms/article.html , plugin org.eclipse.ui.forms) is "User Assistance"? I'd have though either UI, SWT, or JFace ... but "User Assistance"? (In reply to comment #2) > Remy : hummm, the component for Eclipse forms > (http://www.eclipse.org/articles/Article-Forms/article.html , plugin > org.eclipse.ui.forms) is "User Assistance"? I'd have though either UI, SWT, or > JFace ... but "User Assistance"? Forms bugs have always gone to UA. Also see bug 353772 comment 2. (In reply to comment #3) > (In reply to comment #2) > > Remy : hummm, the component for Eclipse forms > > (http://www.eclipse.org/articles/Article-Forms/article.html , plugin > > org.eclipse.ui.forms) is "User Assistance"? I'd have though either UI, SWT, or > > JFace ... but "User Assistance"? > > Forms bugs have always gone to UA. Also see bug 353772 comment 2. Okay, seems a little strange, but as long as the forms team finds the report ... :). I'd quite like to see this fixed, and I'm happy to provide the fix for review. However, for the moment I can't do so because I'm not sure of the use case for why, when the MessageManager has only one message, the choice of whether you show the message itself or a "1 error detected" message depends on whether or not the message has a prefix. Is it not always best to show the error rather than requiring that the user hovers over the message area? I know it's a long time ago (7 years) that Dejan wrote this code - but I'm hoping he might be able to shed some light! (In reply to Ben Cox from comment #5) > I'd quite like to see this fixed, and I'm happy to provide the fix for > review. If we don't hear anything, I'm happy to let you go ahead with this. PW This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |
In org.eclipse.ui.internal.forms.MessageManager#update(ArrayList), at line 513, there is this test : IMessage[] array = (IMessage[]) peers .toArray(new IMessage[peers.size()]); if (peers.size() == 1 && ((Message) peers.get(0)).prefix == null) { <= this one // a single message IMessage message = (IMessage) peers.get(0); Which checks for the message's prefix in order to know whether it should display a single message, or a placeholder with multiple sub messages. However, the message's prefix _cannot_ be null. If it is null, org.eclipse.ui.internal.forms.MessageManager.ControlDecorator#createPrefix() took care of changing it to the empty String, whether we have a IMessagePrefixProvider or not. could the test "((Message) peers.get(0)).prefix == null" be changed to "(((Message) peers.get(0)).prefix == null || ((Message) peers.get(0)).prefix.size() == 0" ?