Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357786

Summary: [KeyBindings] Delete Key is not working in form editor
Product: [Eclipse Project] Platform Reporter: redzack81
Component: UIAssignee: Paul Webster <pwebster>
Status: VERIFIED FIXED QA Contact: Paul Webster <pwebster>
Severity: normal    
Priority: P3 CC: daniel_megert, j.mairboeck, pwebster, remy.suen, Silenio_Quarti
Version: 3.6.2   
Target Milestone: 4.2.2   
Hardware: PC   
OS: Windows XP   
Whiteboard: patch
Attachments:
Description Flags
Patch that adds CCombo as an exception in WorkbenchKeyboard#filterKeySequenceBindings none

Description redzack81 CLA 2011-09-15 08:31:30 EDT 
Build Identifier: 3.6.2.M20110210-1200

Hello,

the delete key (SWT.DEL) is not working properly for CCombo.
Following points have been observed:
- The binding to the delete key seems to eat the keystroke (in WorkbenchKeyboard)
- Although the CCombo internally uses a Text widget, the exception in WorkbenchKeyboard.filterKeySequenceBindings() for the Text widget is not working since the CCombo wraps the event into a new event which has the CCombo set as the events widget.

Seems like either CCombo has to handle this special case differently or WorkbenchKeyboard includes CCombo (like Text, Combo and Browser) as an exception to the out of order processing.

Looks like this is no issue if there is nothing bound to the delete command, but I would expect this to work even with something bound to the command (like the Text widget).

Eclipse: 3.6.2.M20110210-1200
SWT: 3.6.2.v3659c

Reproducible: Always

Steps to Reproduce:
1. Create an FormEditor
2. Add an editable CCombo
3. Add a handler to the command org.eclipse.ui.edit.delete
4. Try using delete in the CCombo
Comment 1 Joachim Mairböck CLA 2012-10-15 04:28:30 EDT 
Created attachment 222288 [details]
Patch that adds CCombo as an exception in WorkbenchKeyboard#filterKeySequenceBindings

I have fixed this by adding CCombo to exception list as proposed in the description.

Note: I have removed the project name from the patch to make it easier to apply it on a plug-in imported as Source Project (without using EGit).
Comment 2 Paul Webster CLA 2012-10-15 09:26:35 EDT 
Silenio, what do you think about making the exception for a CCombo box (in our UI Display filter)?

PW
Comment 3 Silenio Quarti CLA 2012-10-19 11:46:07 EDT 
It seems ok to me, since CCombo is a Text widget and we already have the exception for Text.
Comment 4 Joachim Mairböck CLA 2012-10-20 07:57:54 EDT 
Will this get backported to 4.2.2/3.8.2?
Comment 5 Paul Webster CLA 2012-10-22 08:04:16 EDT 
(In reply to comment #4)
> Will this get backported to 4.2.2/3.8.2?

It won't get backported to 3.8.2.

I'm less sure about 4.2.2, but right now the plan is no.

PW
Comment 7 Paul Webster CLA 2013-01-17 13:41:18 EST 
In M20130116-1800

PW