Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357662

Summary: Build error in o.e.tm.terminal.test/VirtualCanvas when building on Linux-GTK
Product: [Tools] Target Management Reporter: Martin Oberhuber <mober.at+eclipse>
Component: TerminalAssignee: Michael Scharf <eclipse>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: eclipse
Version: 3.3   
Target Milestone: 3.4 M3   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
patch that fixes the problem none

Description Martin Oberhuber CLA 2011-09-14 13:32:47 EDT 
On Linux-GTK, SWT defines Control#getBackgroundColor() as package-private, therefore it is invalid to redefine as protected in subclass VirtualCanvas.

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/tree/bundles/org.eclipse.swt/Eclipse%20SWT/gtk/org/eclipse/swt/widgets/Control.java#n2364

it looks like it's been like this since Eclipse 3.4 (2008) at least:

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/tree/bundles/org.eclipse.swt/Eclipse%20SWT/gtk/org/eclipse/swt/widgets/Control.java?id=aab8dd4993a78017d2de4c49a90a757b1ca40959

This error only shows up when building in PDE on Linux-GTK. Maybe earlier versions of Eclipse didn't highlight this error, or treated it as a warning only. Nighly builds / releng are not affected since tm.terminal.test is not released.
Comment 1 Michael Scharf CLA 2011-09-15 18:28:31 EDT 
Created attachment 203460 [details]
patch that fixes the problem

I just renamed the method that conflicts with the Canvas method on GTK

(I checked this into CVS -- is CVS still used?)
Comment 2 Michael Scharf CLA 2011-09-15 18:32:59 EDT 
Actually, we could also remove this class. As far as I can see it is not used anywhere and I think I created it as an experiment when I developed the terminal because there were some strange problem with scrolling and painting canvas.....
Comment 3 Martin Oberhuber CLA 2011-09-29 13:29:25 EDT 
Thanks Michael - the fix is now in the TM 3.4 (Juno) Stream.