Bug 357621

Comment 1 Gregoire Dupe 2011-09-27 14:22:04 EDT

Good idea but may be not for this year. => P5

Comment 2 Vincent Lorenzo 2012-03-13 05:19:45 EDT

Created attachment 212532 [details]
This patch adds tabs in the ETypedElementSelectionDialog.

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 3 Vincent Lorenzo 2012-03-13 05:23:10 EDT

Created attachment 212533 [details]
icons for the previous patch

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 4 Gregoire Dupe 2012-03-13 10:54:29 EDT

Comment on attachment 212532 [details]
This patch adds tabs in the ETypedElementSelectionDialog.

Partick, please, can you commit this patch.

Regards,
Grégoire

Comment 5 Vincent Lorenzo 2012-03-13 11:18:19 EDT

These icons are already used by the package explorer, in the view menu -> Package Presentation. You can find them in the plugins org.eclipse.search too for example. I rename them for my new feature : flatLayout -> flatView and hierarchicalLayout -> treeView.

Comment 6 Gregoire Dupe 2012-03-13 11:34:20 EDT

Comment on attachment 212533 [details]
icons for the previous patch

Patrick, according to the comment #5, you can commit this contribution.

Comment 7 Patrick Tessier 2012-03-13 11:55:35 EDT

Comment on attachment 212532 [details]
This patch adds tabs in the ETypedElementSelectionDialog.

Here is a contribution from one employee of CEA. The company has signed a
Member Commiter Agreement. The contribution does not need a CQ.
(http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 1812.

Comment 8 Patrick Tessier 2012-03-13 11:55:47 EDT

Comment on attachment 212533 [details]
icons for the previous patch

Here is a contribution from one employee of CEA. The company has signed a
Member Commiter Agreement. The contribution does not need a CQ.
(http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 1812.

Comment 9 Gregoire Dupe 2012-03-23 05:18:41 EDT

This bug can marked as fixed.

Vincent, please, can you check that your contribution has been properly integrated and close this bug ?

Comment 10 Vincent Lorenzo 2012-04-11 05:29:35 EDT

The contribution has not been properly integrated. The new field knownEPackage is not used in the sortedController.

Comment 11 Vincent Lorenzo 2012-04-11 05:31:24 EDT

Created attachment 213839 [details]
Correct this bug in order to use knownEPackage

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 12 Vincent Lorenzo 2012-04-17 10:31:33 EDT

Created attachment 214111 [details]
Correct this bug in order to use knownEPackage + assure that each FacetSet appears in the hierarchical TreeViewer under the correct EPackage

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 13 Vincent Lorenzo 2012-04-27 07:28:23 EDT

Created attachment 214686 [details]
Correct this bug in order to use knownEPackage + assure that each FacetSet appears in the hierarchical TreeViewer under the correct EPackage + correct the method getChildren

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 14 Gregoire Dupe 2012-04-27 08:03:00 EDT

Comment on attachment 214686 [details]
Correct this bug in order to use knownEPackage + assure that each FacetSet appears in the hierarchical TreeViewer under the correct EPackage + correct the method getChildren

This patch modifies less than 250 lines (93 lines).

I've committed this patch.

Committed revision 2141.

Comment 15 Vincent Lorenzo 2012-04-27 09:00:52 EDT

Created attachment 214693 [details]
Rename the tabs and their tooltips

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 16 Vincent Lorenzo 2012-04-27 09:11:23 EDT

Created attachment 214696 [details]
Remove PMD and checkstyle warning in ETypedElementSelectionSortedControl

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 17 Gregoire Dupe 2012-05-03 05:35:04 EDT

Comment on attachment 214693 [details]
Rename the tabs and their tooltips

Here is a patch smaller than 250 lines (11 lines added or modified).

I've committed this patch.

Committed revision 2164.

Comment 18 Gregoire Dupe 2012-05-03 05:47:48 EDT

Comment on attachment 214696 [details]
Remove PMD and checkstyle warning in ETypedElementSelectionSortedControl

Here is a patch smaller than 250 lines (-11 / +14 lines).

I've committed this patch (+ some more cleaning by my self).

Committed revision 2166.

Comment 19 Vincent Lorenzo 2012-05-10 07:37:25 EDT

This bug can be marked as closed.