Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357612

Summary: [disassembly] Missing register tool-tips
Product: [Tools] CDT Reporter: Anton Leherbauer <aleherb+eclipse>
Component: cdt-debugAssignee: Anton Leherbauer <aleherb+eclipse>
Status: RESOLVED FIXED QA Contact: Ken Ryall <ken.ryall>
Severity: enhancement    
Priority: P3 CC: aleherb+eclipse, cdtdoug, jamesblackburn+eclipse, marc.khouzam, pawel.1.piech, pchuong, scott.tepavich
Version: 8.0   
Target Milestone: 8.1.0   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch to be applied
aleherb+eclipse: iplog-
Revised patch aleherb+eclipse: iplog-

Description Anton Leherbauer CLA 2011-09-14 06:04:27 EDT 
+++ This bug was initially created as a clone of Bug #357440 +++

Build Identifier: I20110613-1736

The ability to display the value of registers via tool-tips is missing.

Reproducible: Always
Comment 1 Anton Leherbauer CLA 2011-09-15 03:13:43 EDT 
Created attachment 203385 [details]
Patch to be applied

This patch contains only the hover related changes from the patch attached to bug 357440.  I have also made some cosmetic changes:
- fixed typo "indent" > "ident"
- fixed Copyright date to be Eclipse compliant, .ie. first, last instead of
  first-last
- moved empty default implementations of new methods in IDisassemblyBackend to 
  AbstractDisassemblyBackend
- fixed Java 1.6 API usage: String.isEmpty()
- fixed version in pom.xml (must be same as in MANIFEST.MF)
Comment 2 Anton Leherbauer CLA 2011-09-15 05:33:53 EDT 
(In reply to bug 357440 comment #2)
> It would be nice if the disassembly view passed the selected text if there is
> any.
> 
> Since this bug is requesting for tooltip support, is it possible to have
> tooltip support for instruction documentation? Our customers have been
> requesting to show a short discription when hovering the mouse over the
> instruction in the disassembly view.

I think IDisassemblyBackend.getHoverInfoData(AddressRangePosition, String) should allow for that purpose - if you can provide your own implementation of the IDisassemblyBackend.
Comment 3 Patrick Chuong CLA 2011-09-15 09:48:27 EDT 
(In reply to comment #2)
> I think IDisassemblyBackend.getHoverInfoData(AddressRangePosition, String)
> should allow for that purpose - if you can provide your own implementation of
> the IDisassemblyBackend.

Is this a new API? I don't see it in my local copy of IDisassemblyBackend? Right now, I am using DisassemblyBackendDsf and would like not to have my own implementation if it is possible. Is there any one else that want to have this feature? Perhaps I can create a patch for DisassemblyBackendDsf when I find time to do so.
Comment 4 Anton Leherbauer CLA 2011-09-15 10:15:39 EDT 
Created attachment 203413 [details]
Revised patch

Just noticed that previous patch was not quite complete.

(In reply to comment #3)
> Is this a new API? I don't see it in my local copy of IDisassemblyBackend?

It is API being added by this patch.

> Right now, I am using DisassemblyBackendDsf and would like not to have my own
> implementation if it is possible. Is there any one else that want to have this
> feature? Perhaps I can create a patch for DisassemblyBackendDsf when I find
> time to do so.

Maybe a more flexible approach would be to make the text hover implementation itself exchangeable by different backends, similar to what we do for the text hover in the editor.
Comment 5 Anton Leherbauer CLA 2011-09-16 04:01:15 EDT 
Committed and pushed to master. Thanks!
Comment 6 CDT Genie CLA 2011-09-16 04:23:02 EDT 
*** cdt git genie on behalf of Scott Tepavich ***

    Bug 357612 - [disassembly] Missing register tool-tips

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=9fe6dfee8e88f4ff160c14863f635cf4d8e19816