Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357605

Summary: Remove dependency from IExpressionEditor to BPELPropertySection
Product: z_Archived Reporter: Mickael Istria <mistria>
Component: BPELAssignee: Robert Brodt <bbrodt>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: vincent.zurczak
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Patch with better factorization bbrodt: iplog+

Description Mickael Istria CLA 2011-09-14 05:39:05 EDT 
In order to reuse IExpressionEditors more easily, it would be useful to remove their dependency on BPELPropertySection. Then they could be re-used in Wizards, Editors, and so on.
The current dependency does not seem very useful.
Comment 1 Mickael Istria CLA 2011-09-14 06:29:03 EDT 
Here is the link to a commit that simplifies usage of IExpressionEditor https://github.com/mickaelistria/org.eclipse.bpel/commit/bbf57309515693b5cb83f6adb4f3791780e957e3
Comment 2 Mickael Istria CLA 2011-12-05 07:00:56 EST 
Created attachment 207911 [details]
Patch with better factorization

This patch reduces coupling by useing more abstract class, making it easier to manipulate, re-use, create, and plug ExpressionEditor.
Comment 3 Robert Brodt CLA 2011-12-05 09:07:01 EST 
Sorry Mickail, I've been swamped with work and haven't had the time to work on
BPEL lately.

Vincent or Tobias, can you look at this patch, verify and merge into master
branch?

Thanks all!
Comment 4 Vincent Zurczak CLA 2012-01-05 11:43:36 EST 
The patch was applied.