Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357587

Summary: Custom sorter is changed to SystemTableViewSorter
Product: [Tools] Target Management Reporter: Missing name <mayu>
Component: RSEAssignee: David McKnight <dmcknigh>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: dmcknigh
Version: 3.2.2   
Target Milestone: 3.4 M3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 357961    
Attachments:
Description Flags
patch to update column number for existing sorter
none
updated patch to include regular table view as well
none
updated patch none

Description Missing name CLA 2011-09-14 01:43:28 EDT 
I created a custom sorter that is extended from SystemTableViewSorter.
When I click the header of table view, sorter is changed to SystemTableViewSorter.

The widgetSelected() of HeaderSelectionListener, the inner class of SystemTableTreeView, should use old sorter even if column is not same as older column.
Comment 1 David McKnight CLA 2011-09-14 13:12:45 EDT 
Could you explain how you're adding your custom sorter to the SystemTableTreeView?
Comment 2 David McKnight CLA 2011-09-14 13:21:07 EDT 
Created attachment 203347 [details]
patch to update column number for existing sorter

Could you try with this patch?  I had to add a new method to SystemTableViewSorter however that class is internal.
Comment 3 David McKnight CLA 2011-09-14 13:40:10 EDT 
Created attachment 203350 [details]
updated patch to include regular table view as well
Comment 4 Missing name CLA 2011-09-15 10:50:59 EDT 
I tried new patch. It is OK.
Comment 5 David McKnight CLA 2011-09-15 11:07:47 EDT 
(In reply to comment #4)
> I tried new patch. It is OK.

Do you require a backport to the R3_2_maintenance stream?
Comment 6 Missing name CLA 2011-09-16 03:25:29 EDT 
Please make a backport to the R3_2_maintenance stream.
Comment 7 David McKnight CLA 2011-09-16 12:50:31 EDT 
Created attachment 203499 [details]
updated patch
Comment 8 David McKnight CLA 2011-09-27 09:55:47 EDT 
Kevin, could you please review this patch?
Comment 9 David McKnight CLA 2011-09-30 11:30:02 EDT 
I've committed the fix to the HEAD stream.
Comment 10 Martin Oberhuber CLA 2011-09-30 14:58:11 EDT 
Updated the rse.ui bundle version and released into the mapfile for 3.4m3.