Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357551

Summary:	[dnd] Folder/package dragging onto editor area should be disallowed
Product:	[Eclipse Project] Platform	Reporter:	Remy Suen <remy.suen>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	minor
Priority:	P3	CC:	daniel_megert, markus.kell.r, raksha.vasisht
Version:	3.7
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:	stalebug

Description Remy Suen

2011-09-13 15:52:44 EDT

I20110809-0800

I can drag packages onto the editor area from the 'Package Explorer' view although it seems to do nothing. If the drop will not do anything it should simply be disallowed.

Comment 1 Raksha Vasisht

2011-09-16 07:40:29 EDT

Moving to Platform -UI as the problem lies there.

Also does not work for folders in Navigator. The problem is in the listener

org.eclipse.ui.internal.ide.EditorAreaDropAdapter.dragEnter(...)
 which always sets the event.detail = DND.DROP_COPY;, hence we see the '+' as soon as we drag any element onto the editor area.

There needs to be a check for the event.currentDataType to be one of the supported types in the dragEnter(..) and dragOver(..) as it already exists in the org.eclipse.ui.internal.ide.EditorAreaDropAdapter.asyncDrop(...) but the problem is that event.data is still not set at this point and is only set on 'drop' in 

org.eclipse.jdt.internal.ui.dnd.ResourceTransferDragAdapter.dragSetData(...)

Comment 2 Raksha Vasisht

2011-09-16 07:50:08 EDT

(In reply to comment #1)
 Pl also see bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=74724#c4

Comment 3 Markus Keller

2011-09-16 08:15:12 EDT

Yeah, bug 74724 comment 4 and the Javadoc of org.eclipse.swt.dnd.DropTargetListener#dragEnter(DropTargetEvent) indicate that this may not be solvable in all cases, since the dragged items are only available during the drop operation.

Comment 4 Lars Vogel

2019-11-14 03:51:27 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.