Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357549

Summary:	Palette creation: name and description from ICreationToolEntry are ignored
Product:	[Modeling] Graphiti	Reporter:	Hernan Gonzalez <hjg.com.ar>
Component:	Core	Assignee:	Tim Kaiser <tim.kaiser>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	michael.wenz
Version:	0.8.0	Flags:	michael.wenz: iplog+ tim.kaiser: juno+
Target Milestone:	0.9.0
Hardware:	All
OS:	All
Whiteboard:	Juno M2 Theme_round_offs

Description Hernan Gonzalez

2011-09-13 15:40:59 EDT

Build Identifier: 

A Graphiti ICreationToolEntry has a name and description, which are usually (but no necesarily) taken from the CreateFeature. However, when the GEF PaletteEntry is created (GFPaletteRoot.createTool() method) the name and description are not read from the ICreationToolEntry but from the CreationFeature. 
This is wrong, it turns the ICreationToolEntry name/description useless, and does not allow to create several palette entries which call distinct instantiations of a same CreateFeature

CombinedTemplateCreationEntry pe = new CombinedTemplateCreationEntry(feat.getCreateName(), feat.getCreateDescription(),
template, cf, getImageDescriptor(creationToolEntry, true), getImageDescriptor(creationToolEntry, false));

should be

CombinedTemplateCreationEntry pe = new CombinedTemplateCreationEntry(creationToolEntry.getLabel(), creationToolEntry.getDescription(), template, cf, getImageDescriptor(creationToolEntry, true), getImageDescriptor(creationToolEntry, false));
				


Reproducible: Always

Comment 1 Tim Kaiser

2011-09-21 10:01:58 EDT

correct. i also removed i a useless instanceof check...

Comment 2 Michael Wenz

2012-04-11 10:37:41 EDT

Bookkeeping: Set target release

Comment 3 Michael Wenz

2012-05-09 08:20:32 EDT

Relevant for IP log

Comment 4 Michael Wenz

2012-06-28 10:43:24 EDT

Part of Graphiti 0.9.0 (Eclipse Juno)