Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357501

Summary: [terminal][api] In case of an error on a terminal settings page, no indication is given what's wrong
Product: [Tools] Target Management Reporter: Martin Oberhuber <mober.at+eclipse>
Component: TerminalAssignee: dsdp.tm.core-inbox <tm.core-inbox>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: minor    
Priority: P4 CC: eclipse, uwe.st
Version: 3.3Keywords: api
Target Milestone: 4.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Martin Oberhuber CLA 2011-09-13 10:23:11 EDT
CQ:WIND00253872
Build ID: TM 3.3

Steps to Reproduce:
1. Open the terminal view (Window > Show View > Terminal).
2. Press the "Connection Properties" buttons and pick Telnet connection.
3. Enter a host name, and 77777 as the port number. Press OK.
4. The dialog says the settings are wrong without mentioning what is wrong.

The problem as per a TODO comment in the header of ISettingsPage.java -- the ISettingsPage doesn't provide API for settings implementations to give an error string when validation fails. 

It may be possible for each SettingsPage to use an error indicator on a Field that has a wrong value... but that would require each settingsPage to code the respective UI work, rather than just returning a common error text similar to existing Eclipse Wizard framework.
Comment 1 Uwe Stieber CLA 2015-05-07 02:26:35 EDT
Fixed with TM Terminal 4.0