Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357490

Summary:

[quick assist] Improve wording of new "Convert to *** 'for' loop" quick assists

Product:

[Eclipse Project] JDT

Reporter:

Markus Keller <markus.kell.r>

Component:

Assignee:

Markus Keller <markus.kell.r>

Status:

VERIFIED FIXED

QA Contact:

Severity:

trivial

Priority:

CC:

daniel_megert, deepakazad, markus.kell.r, raksha.vasisht

Version:

3.8

Flags:

daniel_megert: review+

Target Milestone:

3.8 M2

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Fix	daniel_megert: review+

Description Markus Keller

2011-09-13 09:53:22 EDT

Created attachment 203249 [details]
Fix

Follow-up to bug 89432 comment 11:

> "Convert to Iterator for loop" sounds a bit awkward. How about "Convert to
> Iterator based for loop" or "Use Iterator in for loop" ?
> 
> "Convert to indexed for loop" can also be changed accordingly to "Use index
> variable in for loop".

I'd like to keep the "Convert to ...", since this is in sync with the old "Convert to enhanced for loop" and other similar quick assists that perform a behavior-preserving but slightly bigger kind of change than e.g. the "Change ... to ..." quick assists.

I like the "Iterator-based" (but the compound phrase needs a hyphen).

To make the 'for' better readable, I set it in quotes everywhere (as we already do in other places and for other keywords).

Dani, OK for M2? I'd like to use the new strings in the N&N.

Comment 1 Dani Megert

2011-09-13 10:45:15 EDT

Looks good except for missing copyright update in:
/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/cleanup/CleanUpMessages.properties

Comment 2 Markus Keller

2011-09-13 10:51:58 EDT

Thanks, committed to HEAD.

Comment 3 Dani Megert

2011-09-14 04:21:42 EDT

Verified in I20110913-2000.