Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357487

Summary:	Can't install plugin
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Client	Assignee:	Simon Kaegi <simon_kaegi>
Status:	CLOSED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	malgorzata.tomczyk, simon_kaegi
Version:	0.2
Target Milestone:	0.3 M2
Hardware:	PC
OS:	All
Whiteboard:

Description Mark Macdonald

2011-09-13 09:38:48 EDT

Using Orion 2011-09-12

1. Go to Plugins page
2. Enter a plugin url (example: http://mamacdon.github.com/0.3/plugins/bugzilla/plugin.html) and click Install
3. TypeError appears in console, installation times out.

TypeError                       pluginregistry.js:119
  arguments: Array[2]
    0: "resolve"
    1: undefined
    length: 2
    __proto__: Array[0]
  message: "—"
  stack: "—"
  type: "non_object_property_call"
  __proto__: Error

Comment 1 Simon Kaegi

2011-09-13 10:32:53 EDT

Sorry my bad. This is stuff we cannot break.

Comment 2 Simon Kaegi

2011-09-13 10:37:19 EDT

For those interested we were just using postMessage with "strings" but recently switched our plugin story over to using the structured clone algorithm at least for FF and Chrome so we can provide binary support (e.g.ArrayBuffers and Blobs). For backwards compatibility if the received message is a string we need to JSON.parse it first before processing.

Comment 3 Simon Kaegi

2011-09-13 10:55:25 EDT

*** Bug 357495 has been marked as a duplicate of this bug. ***

Comment 4 Simon Kaegi

2011-09-13 10:56:37 EDT

Fixed in HEAD.

Comment 5 Malgorzata Janczarska

2011-09-14 08:40:56 EDT

(In reply to comment #4)
> Fixed in HEAD.
is it? I still see problem described in  Bug 357495 but only on FF now. Can you see it too?

Comment 6 Simon Kaegi

2011-09-14 09:19:36 EDT

The problem in Bug 357495 is not a dup after all -- we were trying to postMessage an error in that case. I'll re-open that one.

Comment 7 Simon Kaegi

2011-10-07 16:21:13 EDT