Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357473

Summary:

Improve test coverage for DeployerArtifact, DefaultArtifactObjectNameCreator and DeployerBundleArtifact

Product:

[RT] Virgo

Reporter:

Florian Waibel <fwaibel>

Component:

runtime

Assignee:

Glyn Normington <glyn.normington>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

glyn.normington, hsiliev

Version:

unspecified

Target Milestone:

3.5.0.RELEASE

Hardware:

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

Bug Depends on:

Bug Blocks:

325617

Attachments:

Description	Flags
Added kernel.core to kernel.model AspectJ inpath to enable @NotNull checks.	glyn.normington: iplog+
Added tests for DeployerBundleArtifact.	glyn.normington: iplog+
Added tests for DeployerArtifact.	glyn.normington: iplog+
Added tests for DefaultArtifactObjectNameCreator.	glyn.normington: iplog+

Description Florian Waibel

2011-09-13 07:50:10 EDT

I added some JUnit tests for:
 * DefaultArtifactObjectNameCreator
 * DeployerArtifact
 * DeployerBundleArtifact

Comment 1 Florian Waibel

2011-09-13 07:50:51 EDT

Created attachment 203237 [details]
Added kernel.core to kernel.model AspectJ inpath to enable @NotNull checks.

Comment 2 Florian Waibel

2011-09-13 07:51:42 EDT

Created attachment 203238 [details]
Added tests for DeployerBundleArtifact.

Comment 3 Florian Waibel

2011-09-13 07:52:07 EDT

Created attachment 203239 [details]
Added tests for DeployerArtifact.

Comment 4 Florian Waibel

2011-09-13 07:52:35 EDT

Created attachment 203240 [details]
Added tests for DefaultArtifactObjectNameCreator.

Comment 5 Glyn Normington

2011-09-13 17:33:53 EDT

Hi Florian

Thanks for the contribution! Great to see more kernel tests.

Please confirm that you wrote 100% of the code and you have the rights to contribute it.

Regards,
Glyn

Comment 6 Florian Waibel

2011-09-14 03:43:17 EDT

You are welcome.
Sorry for the inconvenience caused due to missing confirmation and iplog flag.

I confirm that I have written 100% of the attached patch and that
I'm allowed to contribute the patch to eclipse.org.

Comment 7 Glyn Normington

2011-09-14 09:56:22 EDT

Thanks Florian. Changes pushed as kernel commits 35a8cb0ea0125de205d8b02a769817c14ea5191b and 28633df0f7973d13e74a2d02c250c0263962a6db.