Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357393

Summary:	shell justification field reports "must not be blank" when it is not blank
Product:	Community	Reporter:	David Williams <david_williams>
Component:	Project Management & Portal	Assignee:	Portal Bugzilla Dummy Inbox <portal-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	d_a_carver, wayne.beaton, webmaster
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description David Williams

2011-09-12 11:09:49 EDT

Today I filled in the new Foundation Portal justification field, and when I hit 'submit', got an error, and left me editing that field ... the error message said "must not be blank" and it was obviously not blank. 

I may have had too much detail ... it did ask for detail! :) 

Originally I had 421 characters. I shortened it to 92 characters and then it accepted that. (I also had some blank lines an carriage returns in original, if related to that?). 

If there is a limit, ?256? might want to tell people that, instead of "must not be blank". 

Hope this helps.

Comment 1 Wayne Beaton

2011-09-12 11:12:28 EDT

I'll take a look at the portal code.

Comment 2 Wayne Beaton

2011-09-12 11:20:13 EDT

Justification is stored in a varchar(256) field.  The error message is actually masking the real error that is occuring on the insert attempt.

So... I have a couple of thoughts here:

1) Include some text that states the 256 character warning;
2) Actually show the real error;
3) Put a limit on the number of characters the field will accept.

Since we should be expecting this component to be used a lot in the coming hours and days, I'll do something quick.

Comment 3 Wayne Beaton

2011-09-12 12:46:20 EDT

FWIW, consensus around here is that "I'm David-freakin'-Williams" would serve as sufficient justification.

Comment 4 Denis Roy

2011-09-12 16:09:26 EDT

> I'll do something quick.

How quick is quick?

Comment 5 Wayne Beaton

2011-09-12 16:22:12 EDT

Sorry... I got bogged down trying to get the test environment running. 

Fix to confirm_account.class has been committed. It addresses points #1 and (mostly) #2 from Comment #2.

Comment 6 David Carver

2011-09-13 09:32:40 EDT

(In reply to comment #5)
> Sorry... I got bogged down trying to get the test environment running. 
> 
> Fix to confirm_account.class has been committed. It addresses points #1 and
> (mostly) #2 from Comment #2.

This is still broken.  I still just get a message saying this must not be blank.  I'll shorten my comment, but yes, you need to put some message in there specifyig the max length or something of the comment.

Comment 7 Wayne Beaton

2011-09-13 09:39:28 EDT

Webmaster, can you push out the portal update?

Comment 8 Eclipse Webmaster

2011-09-13 10:37:09 EDT

I've pushed the update into production.

-M.

Comment 9 David Williams

2011-09-19 16:52:56 EDT

should this be marked 'fixed'? (Hard for me to tell :) ... since I can't see it any more)

Comment 10 Wayne Beaton

2011-09-20 20:56:39 EDT

(In reply to comment #9)
> should this be marked 'fixed'? (Hard for me to tell :) ... since I can't see it
> any more)

I say yes.