Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357327

Summary: Small bugfixes for o.e.d.sqltools
Product: [Tools] Data Tools Reporter: Pierre Queinnec <pierre.queinnec>
Component: SQLDevToolsAssignee: Brian Payton <bpayton>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: bpayton
Version: unspecified   
Target Milestone: 1.9.2   
Hardware: Macintosh   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
remove a useless double assignment
none
fix a FileInputStream leak
none
fix a possible infinite loop none

Description Pierre Queinnec CLA 2011-09-11 11:38:03 EDT 
Build Identifier: git master

This is an umbrella ticket for small patches, mostly bugfixes, on the sqltools git master.

Reproducible: Always
Comment 1 Pierre Queinnec CLA 2011-09-11 11:38:54 EDT 
Created attachment 203124 [details]
remove a useless double assignment
Comment 2 Pierre Queinnec CLA 2011-09-11 11:39:38 EDT 
Created attachment 203125 [details]
fix a FileInputStream leak
Comment 3 Pierre Queinnec CLA 2011-09-11 11:40:12 EDT 
Created attachment 203126 [details]
fix a possible infinite loop
Comment 4 Brian Payton CLA 2011-10-04 16:49:01 EDT 
Hi, EGit doesn't like the Git patch format of the supplied patches.  Please use the Eclipse (unified) patch format.  (If you are using Git command line, try "git format-patch --no-prefix")

I applied the patch changes by hand, since the changes were small.
Comment 5 Brian Payton CLA 2011-10-04 17:12:18 EDT 
I've committed the changes.  Here's the Git commit record:

http://git.eclipse.org/c/datatools/org.eclipse.datatools.sqltools.git/commit/?id=f00a03f3d74f7b6284171d28c4f344b187964dfc

Please verify that I did the changes correctly.
Comment 6 Pierre Queinnec CLA 2011-10-05 07:41:33 EDT 
Looks fine, thanks a lot Brian!