| Summary: | pluginManagement configuration of target-platform-configuration may not apply | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Tobias Oberlies <t-oberlies> | ||||||
| Component: | Tycho | Assignee: | Project Inbox <tycho-inbox> | ||||||
| Status: | REOPENED --- | QA Contact: | |||||||
| Severity: | minor | ||||||||
| Priority: | P3 | CC: | igor | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Tobias Oberlies
Please provide sample project and steps to reproduce the problem. Created attachment 229553 [details]
standalone project demonstrating the problem
Created attachment 229555 [details]
example project updated to properly use pluginManagement
pluginManagement does not bind plugin to project build lifecycle, it only defines configuration that will be used when/if the plugin is actually bound. This is how maven always worked and this is not specific to tycho in any way. I've attached updated example that shows how to use pluginManagement properly. Note that we could change tycho to read target-platform-configuration directly from pluginManagement. I am not sure what advantages this will provide however, so will -1 this change unless a compelling reason is provided to justify it. I am closing this bug report as invalid because tycho behaves as designed, but feel free to reopen if you believe we need to change the design. (In reply to comment #4) > feel free to reopen if you believe we need to change the design. This is why I've opened this bug. However I would't expect that this bug is fixed by reading the target-platform-configuration from pluginManagement, but rather when some target-platform-configuration goal in bound Tycho's packaging types. This is something that may happen after bug 353889 is done. Eclipse Tycho is moving away from this bugs.eclipse.org issue tracker to https://github.com/eclipse/tycho/issues/ instead. If this issue is relevant to you, your action is required. 0. Verify this issue is still happening with latest Tycho 2.4.0-SNAPSHOT if issue has disappeared, please change status of this issue to "CLOSED WORKFORME" with some details about your testing environment and how you did verify the issue; and you're done if issue is still present when latest release: * Create a new issue at https://github.com/eclipse/tycho/issues/ ** Use as title in GitHub the title of this Bugzilla ticket (may include the bug number or not, at your own convenience) ** In the GitHub description, start with a link to this bugzilla ticket ** Optionally add new content to the description if it can helps towards resolution ** Submit GitHub issue * Update bugzilla ticket ** Add to "See also" property (up right column) the link to the newly created GitHub issue ** Add a comment "Migrated to <link-to-newly-created-GitHub-issue>" ** Set status as CLOSED MOVED ** Submit All issues that remain open will be automatically closed next week or so. Then the Bugzilla component for Tycho will be archived and made read-only. |