Bug 357166

Comment 1 John Liu 2011-09-08 18:03:01 EDT

Created attachment 203034 [details]
patch to org.eclipse.ptp.rdt.managedbuilder.gnu.ui

Chris, Mike: can you please review and test the patch? Thanks.

Comment 2 Chris Recoskie 2011-09-09 10:44:24 EDT

Some issues...

- You are logging to the wrong activator (should be the one in gnu.ui, not xlc)
- There are API tooling errors since the way your patch is now, the new classes are public.  You should put them in an internal package.
- make sure any patches you post to PTP are iplog-, since you are a committer

Other than that, I tried the patch and it seemed to work well.

Comment 3 John Liu 2011-09-09 15:35:29 EDT

Created attachment 203088 [details]
patch to rdt.managedbuilder.gnu(xlc).ui

update the patch as Chris suggested, also fix the problem in symbol parsing by the spec parsers (both xlc and gnu spec parsers).
Michael and Chris, please review and test this patch. Thanks.

Comment 4 John Liu 2011-09-09 17:00:57 EDT

Created attachment 203093 [details]
patch to rdt.managedbuilder.gnu(xlc).ui

Updated patch after resolving cvs conflicts.

Comment 5 Chris Recoskie 2011-09-12 08:26:25 EDT

Comment on attachment 203093 [details]
patch to rdt.managedbuilder.gnu(xlc).ui

iplog should be -, not +, since you are a committer

Comment 6 Chris Recoskie 2011-09-13 13:17:19 EDT

Created attachment 203264 [details]
updated patch

There were some incorrect @since tags set, and a plugin version increased that didn't need to be.  The attached patch corrects those issues.

Comment 7 John Liu 2011-10-06 10:51:45 EDT

Created attachment 204674 [details]
patch applied to head stream

Comment 8 John Liu 2011-10-06 10:55:34 EDT

(In reply to comment #7)
> Created attachment 204674 [details]
> patch applied to head stream

The patch also update the plugins version for 

plugin				version to update
	

org.eclipse.ptp.rdt.core					4.0.0.q			3.1.100.q		4.0.0.q			4.1.0.q

org.eclipse.ptp.rdt.ui					4.0.0.q			3.1.100.q		4.0.0.q			4.1.0.q		

org.eclipse.ptp.rdt.managedbuilder.gnu.ui	1.0.0.q			1.0.0.q			1.0.0.q			1.1.0.q

org.eclipse.ptp.rdt.managedbuilder.xlc.ui	2.0.1.q			3.1.0.q			3.0.0.q			3.2.0.q

Comment 9 John Liu 2011-10-06 11:00:20 EDT

(In reply to comment #8)
> (In reply to comment #7)
> > Created attachment 204674 [details] [details]
> > patch applied to head stream
> 
> The patch also update the plugins version for 
> 
> plugin                version to update
> 
> 
> org.eclipse.ptp.rdt.core                    4.0.0.q            3.1.100.q       
> 4.0.0.q            4.1.0.q
> 
> org.eclipse.ptp.rdt.ui                    4.0.0.q            3.1.100.q       
> 4.0.0.q            4.1.0.q        
> 
> org.eclipse.ptp.rdt.managedbuilder.gnu.ui    1.0.0.q            1.0.0.q        
>    1.0.0.q            1.1.0.q
> 
> org.eclipse.ptp.rdt.managedbuilder.xlc.ui    2.0.1.q            3.1.0.q        
>    3.0.0.q            3.2.0.q

sorry for the mess, it was submitted by an accident Tab.

Here is the plugins versions updated:

plugin	                                           version updated

org.eclipse.ptp.rdt.core                             4.1.0.q
org.eclipse.ptp.rdt.ui                               4.1.0.q
org.eclipse.ptp.rdt.managedbuilder.gnu.ui            1.1.0.q
org.eclipse.ptp.rdt.managedbuilder.xlc.ui            3.2.0.q

I also fixed the @since tags, this update is reviewed by Greg and Vivian.

Comment 10 Greg Watson 2014-05-29 10:12:23 EDT

Marking this as resolved.