Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357136

Summary: UITopicBase should not include the word "model" in its value
Product: [Eclipse Project] Platform Reporter: Dean Roberts <dean.t.roberts>
Component: UIAssignee: Dean Roberts <dean.t.roberts>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: emoffatt, pwebster, remy.suen
Version: 4.2   
Target Milestone: 4.2 M3   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 357135    
Bug Blocks: 357255    
Attachments:
Description Flags
Remove name model from UITopicBase
none
Example of newly generated UIEvents.java none

Description Dean Roberts CLA 2011-09-08 14:33:31 EDT 
It appears that we are on the eve of creating non-model related events in E4.  That being the case, I don't believe the root constant UITopicBase should really include the word model.

Whether or not this should be expanded to a rename of the field itself is open to debate.  While not the best name, given it is currently being used for model events only ... it may be too pervasive and entrenched to be changed.
Comment 1 Dean Roberts CLA 2011-09-13 14:26:02 EDT 
Created attachment 203280 [details]
Remove name model from UITopicBase

Refactor the topic name slightly by removing "model" from UITopicBase and creating the constant UIModelTopicBase

In preparation of growing non model events.
Comment 2 Dean Roberts CLA 2011-09-13 14:27:29 EDT 
Created attachment 203282 [details]
Example of newly generated UIEvents.java
Comment 3 Eric Moffatt CLA 2011-09-21 09:53:02 EDT 
Pushed to R4_Development in >20110921. Also includes the new UIEvents.java...

commit a35394839071e957aad2a02bc6ac6bdc19f8315f
Comment 4 Eric Moffatt CLA 2011-09-21 09:53:31 EDT 
Marking FIXED.
Comment 5 Dean Roberts CLA 2011-10-26 13:44:11 EDT 
Verified on I20111014-1625