Bugzilla – Full Text Bug Listing
| Summary: | GenTopic should generate UIEvents with comments and javadoc warning supression | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Dean Roberts <dean.t.roberts> | ||||
| Component: | UI | Assignee: | Dean Roberts <dean.t.roberts> | ||||
| Status: | VERIFIED FIXED | QA Contact: | Remy Suen <remy.suen> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | emoffatt, pwebster, remy.suen | ||||
| Version: | 4.2 | ||||||
| Target Milestone: | 4.2 M3 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 357136 | ||||||
| Attachments: |
|
||||||
The app that generates that class is org.eclipse.e4.ui.internal.workbench.swt.GenTopic PW Created attachment 203274 [details]
Patch to add comments and fix copyright
(In reply to comment #2) > Created attachment 203274 [details] > Patch to add comments and fix copyright Can you apply this patch, Dean? It doesn't seem to work for me. Fix pushed to R4_development, thanks Dean. http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=0b7cafe4c5a1c8686bb9d4492bbd70c2016939d4 Verified on I20111014-1625 |
I've been told that UIEvents is a generated class. The generator should probably add a comment that the class is generated. Super deluxe would include comments with instructions on how to run the generator. It should also generate such that it does not contain warnings. A @SuppressWarnings("javadoc") is likely sufficient as it is not clear if the variables need any description more than just the name.