Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357131

Summary:	Clicking on Finish button of velocity template wizard doesn't close the wizard
Product:	[Technology] Tigerstripe	Reporter:	Navid Mehregani <nmehrega>
Component:	UI	Assignee:	Project Inbox <tigerstripe.ui-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	major
Priority:	P3
Version:	unspecified
Target Milestone:	0.5M0
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Navid Mehregani

2011-09-08 14:05:17 EDT

Build Identifier: 

The finish button of the velocity template wizard doesn't close the wizard

Reproducible: Always

Steps to Reproduce:
1. Create a simple generator project in TS
2. Right click on its templates folder > Velocity template
3. Click on Finish.  Notice that the file is created but the wizard is not closed.  I guess for some reason the performFinish() method is returning false!

Comment 1 Navid Mehregani

2011-09-08 14:06:13 EDT

Here's the culprit:


java.lang.NullPointerException
at org.eclipse.tigerstripe.workbench.ui.internal.views.explorerview.JavaNavigatorLabelProvider.dispose(JavaNavigatorLabelProvider.java:91)
at org.eclipse.tigerstripe.workbench.ui.internal.views.explorerview.TigerstripeLabelProvider.dispose(TigerstripeLabelProvider.java:199)
at org.eclipse.jface.viewers.ContentViewer.handleDispose(ContentViewer.java:177)
at org.eclipse.jface.viewers.StructuredViewer.handleDispose(StructuredViewer.java:2302)
at org.eclipse.jface.viewers.ContentViewer$2.widgetDisposed(ContentViewer.java:214)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:123)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:3776)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1367)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1390)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1371)
at org.eclipse.swt.widgets.Widget.release(Widget.java:1216)
at org.eclipse.swt.widgets.Control.release(Control.java:2556)
at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:902)
at org.eclipse.swt.widgets.Widget.release(Widget.java:1219)
at org.eclipse.swt.widgets.Control.release(Control.java:2556)
at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:902)
at org.eclipse.swt.widgets.Widget.release(Widget.java:1219)
at org.eclipse.swt.widgets.Control.release(Control.java:2556)
at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:902)
at org.eclipse.swt.widgets.Widget.release(Widget.java:1219)
at org.eclipse.swt.widgets.Control.release(Control.java:2556)
at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:902)
at org.eclipse.swt.widgets.Widget.release(Widget.java:1219)
at org.eclipse.swt.widgets.Control.release(Control.java:2556)
at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:902)
at org.eclipse.swt.widgets.Widget.release(Widget.java:1219)
at org.eclipse.swt.widgets.Control.release(Control.java:2556)
at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:902)
at org.eclipse.swt.widgets.Widget.release(Widget.java:1219)
at org.eclipse.swt.widgets.Control.release(Control.java:2556)
at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:902)
at org.eclipse.swt.widgets.Widget.release(Widget.java:1219)
at org.eclipse.swt.widgets.Control.release(Control.java:2556)
at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:902)
at org.eclipse.swt.widgets.Canvas.releaseChildren(Canvas.java:267)
at org.eclipse.swt.widgets.Decorations.releaseChildren(Decorations.java:391)
at org.eclipse.swt.widgets.Shell.releaseChildren(Shell.java:1210)
at org.eclipse.swt.widgets.Widget.release(Widget.java:1219)
at org.eclipse.swt.widgets.Control.release(Control.java:2556)
at org.eclipse.swt.widgets.Widget.dispose(Widget.java:625)
at org.eclipse.jface.window.Window.close(Window.java:335)
at org.eclipse.jface.dialogs.Dialog.close(Dialog.java:979)
at org.eclipse.jface.dialogs.TrayDialog.close(TrayDialog.java:179)
at org.eclipse.jface.wizard.WizardDialog.hardClose(WizardDialog.java:871)
at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:819)
at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:430)
at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:624)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:234)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:3776)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1367)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1390)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1375)
at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1187)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3622)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3277)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
at org.eclipse.jface.window.Window.open(Window.java:801)
at org.eclipse.ui.internal.navigator.wizards.WizardShortcutAction.run(WizardShortcutAction.java:98)
at org.eclipse.jface.action.Action.runWithEvent(Action.java:498)
at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:3776)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1367)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1390)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1375)
at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1187)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3622)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3277)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2640)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2604)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2438)
at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:671)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:664)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
at org.eclipse.equinox.launcher.Main.run(Main.java:1407)

Comment 2 Navid Mehregani

2011-09-19 09:45:16 EDT

Fixed

Comment 3 Navid Mehregani

2011-09-19 09:45:32 EDT

Verified.