Bugzilla – Full Text Bug Listing
| Summary: | Source hover does not show any source code | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Maik Musall <maik> | ||||
| Component: | SWT | Assignee: | Lakshmi P Shanmugam <lshanmug> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Silenio Quarti <Silenio_Quarti> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | eclipse.felipe, kim.moir, lshanmug, markus.kell.r, michael, Olivier_Thomann, satyam.kandula, Silenio_Quarti, y29cheng | ||||
| Version: | 3.7 | Flags: | Silenio_Quarti:
review+
|
||||
| Target Milestone: | 3.7.2 | ||||||
| Hardware: | Macintosh | ||||||
| OS: | Mac OS X | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Maik Musall
Additional remark: this bug was present with Mac OS X 10.6 and is still there with 10.7. Do you mean source code from the JDK or from your own source ? I mean my own source codes. The effect is that holding the Shift key does not make a difference, it looks like I wouldn't. I could reproduce the problem on Mac. Moving it to JDT/UI for further analysis. Cocoa, I suppose. The problem is that MouseHover events don't have their stateMask filled in (is always 0). Broken in 3.7 and in I20110906-0905 (didn't check further back). Lakshmi, please investigate. It works fine in 3.6.2. Caused by the changes for bug 332083. Created attachment 203453 [details]
patch
The patch puts back the code in Display. For the MouseHover event, it uses the currentEvent to get the stateMask but not the mouse location.
Silenio, can you please review?
The patch looks ok. Another option would be to get the currentEvent in Widget.setInputState() when the event parameter is null. Comment above was done by me... Modified the patch based on above comments and fixed --> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=cba9ee10aa6ad748491400bbc29d8d3ad5cdfba4 Thanks Silenio! Target Milestone 3.8 M3... does this mean there won't be a fix in 3.7 and this will stay unfixed until 2012? Too bad this was too late for 3.7.1, but I agree it's worth backporting to 3.7.2. Reopening to fix this in 3.7.2. +1 for 3.7.2 +1 for 3.7.2. Is there any way I can get the patch above to my installation of 3.7.1? Is it available in a nightly build or similar? Thanks Silenio! Fixed in R3_7_maintenance branch for 3.7.2 --> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?h=R3_7_maintenance&id=201b8ca7b95929c38e81013b0e83dc557483eb82 (In reply to comment #16) > +1 for 3.7.2. > > Is there any way I can get the patch above to my installation of 3.7.1? Is it > available in a nightly build or similar? The patch will apply to 3.7.1 source, but you'll have to build it yourself. The fix is now in the 3.7.2 branch, it should be available in the next 3.7 maintenance build. Also, the fix is already in the 3.8 stream (you can try the 3.8M3 build). As the original reporter of this bug: thank you all! I'm looking forward to 3.7.2. (In reply to comment #18) > (In reply to comment #16) > > +1 for 3.7.2. > > > > Is there any way I can get the patch above to my installation of 3.7.1? Is it > > available in a nightly build or similar? > The patch will apply to 3.7.1 source, but you'll have to build it yourself. > The fix is now in the 3.7.2 branch, it should be available in the next 3.7 > maintenance build. Also, the fix is already in the 3.8 stream (you can try the > 3.8M3 build). Is there a p2 update site for the 3.7.x maintenance builds? I don't seem to be able to find one that has the 3.7.x M20111102-0800 build which contains the fix for this bug. Apologies for asking the question here, but no one else seems to know this stuff. Not sure if there's an official update site for 3.7.x M-builds. You could try http://download.eclipse.org/eclipse/updates/3.7.x , but you have to uncheck "Group items by category" and choose the Eclipse Platform SDK manually. Yes, there is a p2 repo for maintenance builds http://download.eclipse.org/eclipse/updates/3.7.x http://wiki.eclipse.org/Eclipse_Project_Update_Sites |