Bugzilla – Full Text Bug Listing
| Summary: | [ui] change the order of tab folder creation | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Modeling] EMFCompare | Reporter: | Bouchet Stéphane <sbouchet> | ||||
| Component: | Core | Assignee: | EMF Compare <emf.compare-inbox> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | laurent.goubet | ||||
| Version: | 1.2 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
A fix similar to the provided patch has been contributed on master and will be available in 1.3. Basically, instead of moving the tab folder creation out of the "createContents" method as the patch suggested, we have added a new "createTabFolder" protected method which can be overriden for the purpose of ordering the tabs. Hummmmm, seems that you applied the patch ( or portion of ) because looking at the master branch of emfcompare, the line tabFolder = new CTabFolder(composite, SWT.BOTTOM); is still inside the constructor. git blame give me : 2011-08-18 [353612] patching to simplify the integration of new tabs in the compare viewer ui. see https://github.com/mbarbero/emfcompare/commit/68f964e86206d7549d3e79af90d1022889db0d1c This overlook has now been fixed |
Created attachment 203004 [details] patch Hi, in order to be able to change the order of the displayed tabs, could emf compare ui changes its way its creates its tab folders ? attached is the patch that provides a nice way to integrates tabs.