Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357093

Summary: Cannot use EGLDD files that contain a '.' in the name
Product: z_Archived Reporter: Brian Svihovec <svihovec>
Component: EDTAssignee: Yun Feng Ma <mayunf>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P3 CC: greer, hjiyong, jvincens
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Test EGL Files.
none
Patch none

Description Brian Svihovec CLA 2011-09-08 10:25:48 EDT
Created attachment 202997 [details]
Test EGL Files.

Create a new EGL Client project named "a.b.c".

In the 'client' package, add the two attached egl files.

Create a new Tomcat project named TCP1 (I used Tomcat 6.0) and set it as the target in the a.b.c.egldd file.

Add a new Rest binding in the a.b.c.egldd file with the name MortgageServices

Deploy the .egldd file.

Run the test.html file in TCP1 on a Tomcat 6.0 server using Firebug and you will get an error in the console stating:

"egl.eze$$BindFile_a is undefined"

It looks like ServiceBinder::loadBindFile is having an issue with eglddNames that have a '.' in them on line -  var bindFile = egl[bindFileVar]();
Comment 1 Scott Greer CLA 2011-09-08 19:09:17 EDT
Brian, 

I think you meant to assign this to the Deployment component.....
Comment 2 Yun Feng Ma CLA 2011-10-08 02:25:16 EDT
Created attachment 204787 [details]
Patch

Hi Brian,

The EDT behavior is same with RBD, that means both don't support "." in egldd file name.

The difference between EDT and RBD is that the default egldd file name created by RBD for a project "a.b.c" is "a_b_c.egldd", the egldd file created by EDT is "a.b.c.egldd". I've attached a patch to let EDT has same behavior with RBD.

Another option is supporting "." in egldd file, and replace "." with "_" for the egldd name when do the deployment. But maybe this will confuse users who want to use the egldd file name explicitly in their egl codes.

Let me know if you have any concerns about the current fix. Thanks.
Comment 3 Brian Svihovec CLA 2011-10-11 10:49:34 EDT
Yun Feng,

I talked about this issue with Joe, and he agrees that the EGLDD file name should be passed through an 'aliaser', since it's a file name AND a method name (at least in JS).

I think that the attached patch is valid for .7, and possibly beyond.  Please commit your patch and resolve this defect.

For future reference, I believe the DD file should not need to be aliased when it is created, and it should be aliased when it is 'deployed', according to the rules specified in our JavaAliaser and our JavaScriptAliaser.  We can deal with this issue in the future if it comes up.
Comment 4 Yun Feng Ma CLA 2011-10-11 20:36:02 EDT
Thanks, Brian, for the review. The change is in, now resolve this bug.
Comment 5 Lisa Lasher CLA 2012-04-04 22:45:37 EDT
this was fixed in 0.7 GA