Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357073

Summary: MIDataDisassemble should support modes 2 and 3 added in GDB 7.3
Product: [Tools] CDT Reporter: Daniel Thomas <daniel.thomas>
Component: cdt-debugAssignee: Marc Khouzam <marc.khouzam>
Status: RESOLVED FIXED QA Contact: Ken Ryall <ken.ryall>
Severity: normal    
Priority: P3 CC: cdtdoug, marc.khouzam, pawel.1.piech
Version: 8.0Flags: marc.khouzam: review? (jamesblackburn+eclipse)
Target Milestone: 8.1.0   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 357270    
Attachments:
Description Flags
Add support for modes 2 and 3 to MIDataDissassemble
none
Also patch DSF
marc.khouzam: iplog+
Patch committed to master marc.khouzam: iplog-

Description Daniel Thomas CLA 2011-09-08 08:40:20 EDT 
Build Identifier: 

In GDB 7.3 -data-disassemble MI gained support for modes 2 and 3 for dumping the instruction opcodes. MIDataDisassemble should support those modes.

I have a patch which adds support for this.


Reproducible: Always
Comment 1 Daniel Thomas CLA 2011-09-08 08:41:13 EDT 
Created attachment 202984 [details]
Add support for modes 2 and 3 to MIDataDissassemble
Comment 2 Marc Khouzam CLA 2011-09-08 09:54:55 EDT 
A similar patch would apply to DSF-GDB:
/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MIDataDisassemble.java
Comment 3 Daniel Thomas CLA 2011-09-08 10:10:12 EDT 
Created attachment 202990 [details]
Also patch DSF

Updated patch to also cover DSF-GDB.
Comment 4 Marc Khouzam CLA 2011-09-09 13:55:32 EDT 
Can you please confirm in this bug that:
1- you have written 100% of the patch
2- you have the right to contribute the code to eclipse

Also, what copyright should we put at the top of the files?
Should be like:
"Daniel Thomas (<company>) - Added support for mode 2 and 3 (Bug 357073)"
Comment 5 Daniel Thomas CLA 2011-09-12 06:32:47 EDT 
(In reply to comment #4)
> Can you please confirm in this bug that:
> 1- you have written 100% of the patch
I wrote 100% of this patch having examined a similar work by James Blackburn.

> 2- you have the right to contribute the code to eclipse
I have confirmed that I have the right to contribute this code to eclipse.

> Also, what copyright should we put at the top of the files?
> Should be like:
> "Daniel Thomas (<company>) - Added support for mode 2 and 3 (Bug 357073)"

"Broadcom core (Broadcom) - Added support for mode 2 and 3 (Bug 357073)"
Do you want me to update the patch to contain that?
Comment 6 Daniel Thomas CLA 2011-09-12 06:50:36 EDT 
(In reply to comment #5)
> "Broadcom core (Broadcom) - Added support for mode 2 and 3 (Bug 357073)"
> Do you want me to update the patch to contain that?
BWIM:

"Broadcom Corp. - Added support for mode 2 and 3 (Bug 357073)"
Comment 7 Marc Khouzam CLA 2011-09-12 09:39:38 EDT 
Created attachment 203158 [details]
Patch committed to master

I committed this patch to master.
Comment 8 Marc Khouzam CLA 2011-09-12 09:41:50 EDT 
The patch I committed also modified the CommandFactory classes for both CDI and DSF.

James, can you review?

Thanks Daniel for the contribution.
Comment 9 CDT Genie CLA 2011-09-12 10:23:02 EDT 
*** cdt git genie on behalf of Daniel Thomas ***

    Bug 357073: MIDataDisassemble should support modes 2 and 3 added in GDB 7.3

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=6d7a8182a01e264b6726f48e9bf29e9bd774d753