Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357027

Summary: [Eclipse]Deployment web project got compile error on dojox.gfx.resources.svg2gfx.xsl
Product: z_Archived Reporter: Xin Wu <cdlwuxin>
Component: EDTAssignee: Huang Ji Yong <hjiyong>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: broy2, cdlwuxin, hjiyong, jinfahua, opepermans, smythew, svihovec
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
View the developer sees after deploying a RUI project none

Description Xin Wu CLA 2011-09-07 22:20:41 EDT
Build Identifier: 20110908 nightly build

Deployment web project got compile error on dojox.gfx.resources.svg2gfx.xsl.
When deploy project referenced dojo widget project, the target web project got this compile error in webcontent folder

Reproducible: Always

Steps to Reproduce:
1. Create Client project and automatically import dojo widget project
2. Deploy the project to target web project
3. You can see the compile error in WebContent.dojox.gfx.resources.svg2gfx.xsl
Comment 1 fahua jin CLA 2011-10-11 23:10:19 EDT
More detailed error information:

Description	Resource	Path	Location	Type
Xpath is invalid	svg2gfx.xsl	/TestRUITarget/WebContent/dojox/gfx/resources	line 731	XSL Problem
Comment 2 Yun Feng Ma CLA 2011-10-21 04:16:31 EDT
An Eclipse bug is opened for this: bug 328051.
Comment 3 fahua jin CLA 2011-11-06 20:19:34 EST
Eric or Jimmy,

Could you please change the subject of this defect - add [Eclipse] to the headline.  Also, set target milestone to Future. Thank you!
Comment 4 Yun Feng Ma CLA 2011-11-09 21:43:59 EST
*** Bug 363096 has been marked as a duplicate of this bug. ***
Comment 5 Will Smythe CLA 2011-11-18 23:13:45 EST
I really think we need to consider doing something about this for 0.7. It does not give a good/warm feeling seeing a big red X on your project after deploying. This is an error every developer using Dojo (which will be almost everyone) will see on deployment and will want to go investigate.

I understand this is an Eclipse/Dojo issue, but I think we should do something about it, even if that means not shipping these files (which I don't think we use anyway) or excluding them during deployment (yes, this sounds like hack).

I am setting the target milestone to 0.7 Final so it can be considered.
Comment 6 Will Smythe CLA 2011-11-18 23:14:18 EST
Created attachment 207262 [details]
View the developer sees after deploying a RUI project
Comment 7 Brian Svihovec CLA 2011-11-19 17:04:16 EST
According to the defect mentioned in comment 2, the Eclipse recommendation is that these errors get converted to warnings by changing the validation properties on the project.  

When deploying to a web project, maybe we can change the validation properties to mark these errors as a warning.  From comment 7 in the Eclipse defect, "The work around is to
lower the severity of the XPath errors in the XSL preference pages, you can do
this on a per project basis."

If we are not using these files we can investigate removing them from our local Dojo runtime project, but I wonder if the issue would move to another file?
Comment 8 Will Smythe CLA 2011-11-21 11:37:50 EST
Brian - the errors look contained to 1 file.

As I stated before, I think we need to do *something* to avoid errors from showing on a simple project (even Hello World) after running the deployment operation. This will not give new users a very positive first impression of deployment.
Comment 9 Brian Svihovec CLA 2011-11-21 13:30:18 EST
*** Bug 364392 has been marked as a duplicate of this bug. ***
Comment 10 Will Smythe CLA 2011-11-21 16:02:06 EST
I confirmed with Chris Mitchell (IBM Dojo committer) that this is a utility file, and not used or required at runtime. Its purpose is to convert existing SVG graphic files into Dojo's GFX serialization format.

I recommend we not deploy this file to avoid the compile error all together. 

Note: I consider this solution temporary, in that we need to get a lot smarter about which Dojo files we deploy. Currently we are deploying everything. This slows the deployment process and publishing to a server. I have opened a bug to investigate this - Bug 364415 - Investigate being smarter about what Dojo files need to get deployed
Comment 11 Brian Svihovec CLA 2011-11-21 21:14:24 EST
Ji Yong,  please remove this file from our local Dojo project so that it is no longer deployed.
Comment 12 Huang Ji Yong CLA 2011-11-22 00:25:35 EST
Delete dojox.gfx.resources.svg2gfx.xsl from cvs
Comment 13 Xin Wu CLA 2011-11-22 20:41:05 EST
Verified in build 20111122