Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357016

Summary: ModuleCoreNature projects should respect defaultRootSource
Product: [WebTools] WTP Java EE Tools Reporter: Carl Anderson <ccc>
Component: jst.j2eeAssignee: Diego Sahagun <diegosr>
Status: RESOLVED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: normal    
Priority: P3 Flags: cbridgha: review+
Version: 3.2.4   
Target Milestone: 3.2.5   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 121460, 357866, 365135    
Bug Blocks: 358777, 360265    
Attachments:
Description Flags
Fix patch ccc: iplog+

Description Carl Anderson CLA 2011-09-07 17:41:45 EDT
Currently, if a Java EE facet is added to an existing ModuleCoreNature project, it overwrites the existing defaultRootSource with a new one, and does not take that defaultRootSource into account for the corresponding value.

We need to respect previously set defaultRootSource values.
Comment 1 Diego Sahagun CLA 2011-09-07 17:52:46 EDT
Created attachment 202944 [details]
Fix patch

The ModelProviders are updated such that, if the project exists, is a ModuleCore project and the defaultRootSource exists, that value is used as the default instead of the product-defined default.

Also unnecessary '/' characters were removed from the InstallDelegates, which allows for the values read by the ModelProviders to be used.
Comment 2 Chuck Bridgham CLA 2011-09-12 10:08:45 EDT
approved
Comment 3 Carl Anderson CLA 2011-09-12 15:25:43 EDT
Committed to HEAD and R3_2_maintenance for WTP 3.4.0 and WTP 3.2.5 respectively.  Please clone this bug for WTP 3.3.2.