Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356974

Summary:	Remove user rights on project deletion
Product:	[ECD] Orion	Reporter:	John Arthorne <john.arthorne>
Component:	Server	Assignee:	John Arthorne <john.arthorne>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	0.4 M1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description John Arthorne

2011-09-07 13:08:27 EDT

0.3 M1

When a project is deleted, we do not delete the user rights entry for that project. I can see from the metadata that I have a very long list of user rights for things that no longer exists...

Comment 1 John Arthorne

2011-10-21 09:12:46 EDT

*** Bug 360277 has been marked as a duplicate of this bug. ***

Comment 2 John Arthorne

2011-10-21 13:36:35 EDT

While working on this I discovered some of the user rights are redundant anyway. When we create a project 'B' in workspace 'A', we add the following rights:

/workspace/A/project/B
/workspace/A/project/B/*
/file/B
/file/B/*

However the first two are redundant. The user will already have rights to:

/workspace/A/*

Because of their workspace ownership. So all we need to add when a project is created is:

/file/B
/file/B/*

Comment 3 John Arthorne

2011-10-21 13:42:49 EDT

Fix and regression tests:

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?h=bug356974&id=33446db3caa287227df44691e9222fcd18e56464

Comment 4 John Arthorne

2011-10-24 11:43:32 EDT

Pushed to master:

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=33446db3caa287227df44691e9222fcd18e56464

Comment 5 John Arthorne

2012-06-08 16:12:27 EDT

For cross-reference, this bug only fixed the file servlet. Similar code is used in the Git servlet which was not fixed. See bug 382147 for the git servlet case.