Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356962

Summary:	Wrong minimum version to o.e.pde.core
Product:	z_Archived	Reporter:	Kaloyan Raev <kaloyan>
Component:	Libra	Assignee:	Holger Staudacher <holger.staudacher>
Status:	RESOLVED FIXED	QA Contact:	Holger Staudacher <holger.staudacher>
Severity:	normal
Priority:	P3	Flags:	kaloyan: review+
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows Vista
Whiteboard:

Description Kaloyan Raev

2011-09-07 12:12:15 EDT

While fixing bug 349783, I have noticed that the o.e.libra.warproducts.core plugin does not compile against Helios target platform. The o.e.libra.warproducts.core.WARProduct class imports an internal PDE class o.e.pde.internal.core.iproduct.IConfigurationProperty interface that is not available in version 3.6.0 of the o.e.pde.core plugin, but has been introduced in version 3.7.0. However, in the warproduct's bundle manifest the minimum version for the o.e.pde.core dependency is pointed to 3.6.0. This means that the WAR Products feature can install successfully on Helios, but may fail later with runtime errors. 

I see two possible solutions for this issue:
1) rework the code to remove the dependency to this internal PDE interface. 
2) set the o.e.pde.core dependency with correct minimum version - 3.7.0.

Comment 1 Kaloyan Raev

2011-09-07 12:12:48 EDT

It would be best if this can be fixed soon, so it can go in Indigo SR1.

Comment 2 Holger Staudacher

2011-09-12 05:01:52 EDT

Thanks for reporting. This is fixed in our master.

Comment 3 Kaloyan Raev

2011-09-12 05:09:59 EDT

"fixed in master" means that it's fixed for Juno and will be available with M2. 

Do you want to fixes this for the Indigo stream too? If, yes then you need to push the change to the indigo branch. Let me know if you want to do this. There is no problem to declare one more M-build for Indigo SR1 with this fix.

Comment 4 Holger Staudacher

2011-09-12 05:39:42 EDT

Hey Kaloyan. I think it would be good to have it in Indigo SR1. I jus tneed to figure out how to commit in this branch. I tried it but with no success. Will keep you posted.

Comment 5 Kaloyan Raev

2011-09-12 05:48:58 EDT

You should be able to easily cherry-pick your change from 'master' to 'indigo'. Check this guide: http://wiki.eclipse.org/EGit/User_Guide#Cherry_Picking

Comment 6 Holger Staudacher

2011-09-12 07:37:17 EDT

Thanks for this tip. Every day you learn a new thing about git ;)

Done, can you verify it?

Comment 7 Kaloyan Raev

2011-09-12 08:22:42 EDT

Looks like the cherry picking worked well. I also verified that the latest Hudson build does not install successfully on Helios - shows a p2 dependency not satisfied error (which is OK). 

However, since you did a change in these plug-ins, you now must increment their version from '0.1.0.qualifier' to a higher one - like '0.1.1.qualifier'. Could you do this? In both branches.

Comment 8 Holger Staudacher

2011-09-12 12:06:30 EDT

Done, thanks for pointing this out ;)

Comment 9 Kaloyan Raev

2011-09-12 15:58:53 EDT

One more thing left :)

Now the build fails because of:

Unqualified OSGi version 0.1.1.qualifier must match unqualified Maven version 0.1.0-SNAPSHOT for SNAPSHOT builds


See https://hudson.eclipse.org/hudson/job/libra-indigo/55/console
and https://hudson.eclipse.org/hudson/job/libra/106/console

You need to change the version also in the pom.xml so it matches the one in the manifest. Otherwise, Tycho will keep complaining like this.

Comment 10 Holger Staudacher

2011-09-13 09:27:34 EDT

Done ;)

Comment 11 Kaloyan Raev

2011-09-13 09:35:25 EDT

Build is still failing. 

It seems like you changed the wrong version number. As far as I can see you change the version of the bundle's reference to the parent project. And the build fails because there is no parent pom with version 0.1.1-SNAPSHOT

If the bundle does not specify a version in its pom.xml then it inherits the one from the parent pom, which is 0.1.0-SNAPHOST. In this case you must add a version tag for the bundle explicitly.

Comment 12 Kaloyan Raev

2011-09-13 11:15:16 EDT

Holger, I went ahead and fixed those poms. You can check the change here: 

http://git.eclipse.org/c/libra/org.eclipse.libra.git/commit/?h=indigo&id=5075889ffe61eea7afe2c5770b93c33232300f0b

I will release the M-build later today.

Comment 13 Kaloyan Raev

2011-09-13 11:57:37 EDT

I had to increment also the version of the WAR Product feature and adjust the category.xml so the new version appear correctly in the p2 repository.