Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356860

Summary: TVT/DVT3.7:TCT98: TVT_PTB: "Theme" dropdown is in English on Preferences>General>Appearance
Product: [Eclipse Project] Platform Reporter: CDE Administration <cdeadmin>
Component: UIAssignee: Remy Suen <remy.suen>
Status: VERIFIED FIXED QA Contact: Remy Suen <remy.suen>
Severity: critical    
Priority: P3 CC: camle, dj.houghton, emoffatt, ericchen, hwfu, john.arthorne, keithc, kitlo, kqli, ob1.eclipse, pwebster, remy.suen
Version: 4.1   
Target Milestone: 4.2 M2   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 356997    
Attachments:
Description Flags
033.001.440_pt_BR.jpg
none
033.001.440_eng_98.gif
none
03.001.440.jpg
none
033.001.440_de.gif
none
String externalization patch v1
none
TCT98_033.001.440_kor.gif
none
98_033.001.440_EngStr.gif none

Description CDE Administration CLA 2011-09-06 16:33:43 EDT
<response_by> Carlos Marques at 2011.09.06.13.42.23 </response_by>
Build: 20110825-1600
Language: Brazilian Portuguese

Steps To Recreate Problem:
1.  Start Eclipse by double clicking eclipse.exe in the folder that you unzipped Eclipse (ex C:\Eclipse)
2.  Click Window on the main menu at the top.
3.  Select Preferences
4.  In the tree, select General > Appearance
5.  Verify the panel below is correctly displayed

Problem Description:
Drop-down values are in English, please see screenshot.

thanks

carlos

<response_by> David K at 2011.09.06.15.24.44 </response_by>
This article was reassigned from Category:''TVT/Testing,WSW37(IES),Inbox''.
Comment 1 CDE Administration CLA 2011-09-06 16:33:47 EDT
Created attachment 202842 [details]
033.001.440_pt_BR.jpg
Comment 2 CDE Administration CLA 2011-09-06 16:33:49 EDT
<cde:tctdetail>
Testcase: 033.001.440 - BASE41 MANAGE CONFIGURATION - APPEARANCE
Project: WSW37B
Component: Xfer - e4/UI
Priority: 1
Subject: TVT_PTB: "Theme" dropdown is in English on Preferences>General>Appearance
Article ID: 98
Originator: marquesc@br.ibm.com
Stop Ship: T
</cde:tctdetail>
Comment 3 CDE Administration CLA 2011-09-07 02:44:11 EDT
<response_by> Keiko Terada at 2011.09.07.01.30.19 </response_by>
same problem in Japanese
Comment 4 CDE Administration CLA 2011-09-07 02:44:13 EDT
Created attachment 202858 [details]
033.001.440_eng_98.gif
Comment 5 CDE Administration CLA 2011-09-07 10:34:02 EDT
<response_by> maria cristina caroletti at 2011.09.07.09.20.23 </response_by>
Same for IT

Alessandro
Comment 6 CDE Administration CLA 2011-09-07 10:34:04 EDT
Created attachment 202903 [details]
03.001.440.jpg
Comment 7 DJ Houghton CLA 2011-09-07 11:20:09 EDT
Cam, which version of Eclipse is this? I'm guessing 4.x since the bug was originally reported against e4/UI.
Comment 8 Remy Suen CLA 2011-09-07 11:25:25 EDT
The labels are hardcoded in the plugin.xml of our R4_HEAD org.eclipse.platform bundle.
Comment 9 CDE Administration CLA 2011-09-07 11:43:55 EDT
<response_by> Bernd Kornas at 2011.09.07.10.40.05 </response_by>
Hi,

same problem exist for German.

Regards, Bernd
Comment 10 CDE Administration CLA 2011-09-07 11:43:56 EDT
Created attachment 202913 [details]
033.001.440_de.gif
Comment 11 CDE Administration CLA 2011-09-07 11:43:59 EDT
<cde:tctdetail>
Testcase: 033.001.440 - BASE41 MANAGE CONFIGURATION - APPEARANCE
Project: 
Component: Xfer - e4/UI
Priority: 1
Subject: TVT_PTB: "Theme" dropdown is in English on Preferences>General>Appearance
Article ID: 98
Originator: marquesc@br.ibm.com
Stop Ship: T
</cde:tctdetail>
Comment 12 Remy Suen CLA 2011-09-07 11:45:20 EDT
Created attachment 202914 [details]
String externalization patch v1
Comment 13 CDE Administration CLA 2011-09-07 12:12:28 EDT
<cde:tctdetail>
Testcase: 033.001.440 - BASE41 MANAGE CONFIGURATION - APPEARANCE
Project: WSW37B
Component: Xfer - e4/UI
Priority: 1
Subject: TVT_PTB: "Theme" dropdown is in English on Preferences>General>Appearance
Article ID: 98
Originator: marquesc@br.ibm.com
Stop Ship: T
</cde:tctdetail>
Comment 14 DJ Houghton CLA 2011-09-07 12:16:13 EDT
Released patch into R4_HEAD branch. 
Tagged as v20110907-1200.
Not sure where the map file is, can someone update that for the build submission? 
Thanks.
Comment 15 Remy Suen CLA 2011-09-07 13:23:53 EDT
(In reply to comment #14)
> Released patch into R4_HEAD branch. 
> Tagged as v20110907-1200.

Thanks, DJ.

> Not sure where the map file is, can someone update that for the build
> submission? 

I have updated the feature.map file in org.eclipse.e4.sdk.
Comment 16 CDE Administration CLA 2011-09-07 22:23:59 EDT
<response_by> SeYeon Lee at 2011.09.07.21.19.21 </response_by>
same for Korean.

Thanks,
Seyeonh
Comment 17 CDE Administration CLA 2011-09-07 22:24:00 EDT
Created attachment 202954 [details]
TCT98_033.001.440_kor.gif
Comment 18 CDE Administration CLA 2011-09-08 03:03:42 EDT
<response_by> Katia Milekhina at 2011.09.08.01.49.57 </response_by>
Same problem for Russian.

Regards.
Katia
Comment 19 CDE Administration CLA 2011-09-08 08:02:39 EDT
<response_by> Manuel Ferro at 2011.09.08.06.52.21 </response_by>
Same for Portuguese_Portugal.

Regards,
Andr? Ferreira
Comment 20 CDE Administration CLA 2011-09-08 08:43:53 EDT
<response_by> Henriette Hagemann at 2011.09.08.07.21.39 </response_by>
And for Danish
Comment 21 DJ Houghton CLA 2011-09-08 08:47:35 EDT
Yes, the results should be the same for all non-English languages. The strings were hard-coded and not externalized.  (as mentioned in comment 8)
Comment 22 CDE Administration CLA 2011-09-08 09:24:02 EDT
<response_by> Eric Ma at 2011.09.08.08.06.43 </response_by>
Same for CHS.  Pls send the N&C file for translation.
Comment 23 CDE Administration CLA 2011-09-08 09:24:04 EDT
Created attachment 202987 [details]
98_033.001.440_EngStr.gif
Comment 24 CDE Administration CLA 2011-09-08 09:24:08 EDT
<cde:tctdetail>
Testcase: 033.001.440 - BASE41 MANAGE CONFIGURATION - APPEARANCE
Project: 
Component: Xfer - e4/UI
Priority: 1
Subject: TVT_PTB: "Theme" dropdown is in English on Preferences>General>Appearance
Article ID: 98
Originator: marquesc@br.ibm.com
Stop Ship: T
</cde:tctdetail>
Comment 25 CDE Administration CLA 2011-09-08 10:43:29 EDT
<response_by> Gert-Jan Goedhart at 2011.09.08.09.39.50 </response_by>
same for Dutch
thx
Comment 26 CDE Administration CLA 2011-09-09 06:04:03 EDT
<response_by> Eug?nia Torrella at 2011.09.09.04.48.49 </response_by>
Same for Spanish.

Thanks and regards,

Eug?nia Torrella

<response_by> euroscript Polska at 2011.09.09.05.01.59 </response_by>
Same for Polish.
Thanks,
Greg
Comment 27 CDE Administration CLA 2011-09-09 09:44:03 EDT
<response_by> Gaelle Lacoste at 2011.09.09.08.29.53 </response_by>
Hello,
Same for French.
Thanks in advance,
Gaelle
Comment 28 John Arthorne CLA 2011-09-09 12:05:30 EDT
> same problem in Japanese
> same for Korean.
> Same for Spanish.
> Same for Polish.
> same for Dutch
> Same problem for Russian.
> Same for Portuguese_Portugal.

The text is NOT EXTERNALIZED. This means it will be the same in EVERY LANGUAGE.
Comment 29 CDE Administration CLA 2011-09-09 12:10:50 EDT
<cde:tctdetail>
Testcase: 033.001.440 - BASE41 MANAGE CONFIGURATION - APPEARANCE
Project: WSW37B
Component: Xfer - e4/UI
Priority: 1
Subject: TVT_PTB: "Theme" dropdown is in English on Preferences>General>Appearance
Article ID: 98
Originator: marquesc@br.ibm.com
Stop Ship: T
</cde:tctdetail>
Comment 30 CDE Administration CLA 2011-09-09 16:23:56 EDT
<response_by> Carlos Marques at 2011.09.09.15.13.25 </response_by>
Guys, can you please clarify what "NOT EXTERNALIZED" means? Does this mean you will not be sending out these strings for translation?

Also, we respond to TCTs saying "same for <country>" so we can track this later.
Comment 31 CDE Administration CLA 2011-09-09 16:23:59 EDT
<cde:tctdetail>
Testcase: 033.001.440 - BASE41 MANAGE CONFIGURATION - APPEARANCE
Project: 
Component: Xfer - e4/UI
Priority: 1
Subject: TVT_PTB: "Theme" dropdown is in English on Preferences>General>Appearance
Article ID: 98
Originator: marquesc@br.ibm.com
Stop Ship: N
</cde:tctdetail>
Comment 32 John Arthorne CLA 2011-09-09 17:22:07 EDT
Not externalized means the English string was hard-coded in the application. It doesn't matter what locale you use, the string will show up in English. This was not intended - it is a valid bug that has now been fixed.
Comment 33 CDE Administration CLA 2011-09-09 17:30:53 EDT
<cde:tctdetail>
Testcase: 033.001.440 - BASE41 MANAGE CONFIGURATION - APPEARANCE
Project: WSW37B
Component: Xfer - e4/UI
Priority: 1
Subject: TVT_PTB: "Theme" dropdown is in English on Preferences>General>Appearance
Article ID: 98
Originator: marquesc@br.ibm.com
Stop Ship: N
</cde:tctdetail>
Comment 34 Remy Suen CLA 2011-09-13 08:47:32 EDT
Verified by source inspection with I20110912-0200.
Comment 35 CDE Administration CLA 2011-09-19 10:24:07 EDT
<response_by> Bernd Kornas at 2011.09.19.09.03.57 </response_by>
Fixed for German in Pass 2 (20110917).

Thanks and regards, Bernd
Comment 36 CDE Administration CLA 2011-09-19 10:24:11 EDT
<cde:tctdetail>
Testcase: 033.001.440 - BASE41 MANAGE CONFIGURATION - APPEARANCE
Project: 
Component: 
Priority: 1
Subject: TVT_PTB: "Theme" dropdown is in English on Preferences>General>Appearance
Article ID: 98
Originator: marquesc@br.ibm.com
Stop Ship: N
</cde:tctdetail>
Comment 37 CDE Administration CLA 2011-09-20 00:32:45 EDT
<response_by> Keiko Terada at 2011.09.19.23.13.33 </response_by>
Fixed for Japanese in Pass 2 (20110917).  Thanks.
Comment 38 CDE Administration CLA 2011-09-20 00:32:48 EDT
<cde:tctdetail>
Testcase: 033.001.440 - BASE41 MANAGE CONFIGURATION - APPEARANCE
Project: WSW37B
Component: Xfer - e4/UI
Priority: 1
Subject: TVT_PTB: "Theme" dropdown is in English on Preferences>General>Appearance
Article ID: 98
Originator: marquesc@br.ibm.com
Stop Ship: N
</cde:tctdetail>
Comment 39 CDE Administration CLA 2011-09-20 04:16:03 EDT
<response_by> Katia Milekhina at 2011.09.20.02.55.46 </response_by>
Fixed for Russian.

Regards,
Katia
Comment 40 CDE Administration CLA 2011-09-20 05:14:28 EDT
<response_by> Manuel Ferro at 2011.09.20.03.55.06 </response_by>
Fixed for Portuguese_Portugal.

Regards,
Andr? Ferreira
Comment 41 CDE Administration CLA 2011-09-20 06:24:13 EDT
<response_by> Gaelle Lacoste at 2011.09.20.05.07.46 </response_by>
Hello,
Fixed for French in pass#2.
Thanks for your help,
Gaelle
Comment 42 CDE Administration CLA 2011-09-20 06:24:16 EDT
<cde:tctdetail>
Testcase: 033.001.440 - BASE41 MANAGE CONFIGURATION - APPEARANCE
Project: 
Component: Xfer - e4/UI
Priority: 1
Subject: TVT_PTB: "Theme" dropdown is in English on Preferences>General>Appearance
Article ID: 98
Originator: marquesc@br.ibm.com
Stop Ship: N
</cde:tctdetail>
Comment 43 CDE Administration CLA 2011-09-20 07:04:04 EDT
<response_by> euroscript Polska at 2011.09.20.05.54.32 </response_by>
Fixed for Polish.

Thanks,
Greg
Comment 44 CDE Administration CLA 2011-09-20 07:04:09 EDT
<cde:tctdetail>
Testcase: 033.001.440 - BASE41 MANAGE CONFIGURATION - APPEARANCE
Project: 
Component: 
Priority: 1
Subject: TVT_PTB: "Theme" dropdown is in English on Preferences>General>Appearance
Article ID: 98
Originator: marquesc@br.ibm.com
Stop Ship: N
</cde:tctdetail>
Comment 45 CDE Administration CLA 2011-09-20 15:34:24 EDT
<response_by> Carlos Marques at 2011.09.20.14.10.17 </response_by>
Fixed for Brazil. If anyone needs this TCT reopened please let me know.
Comment 46 CDE Administration CLA 2011-09-20 15:34:27 EDT
<cde:tctdetail>
Testcase: 033.001.440 - BASE41 MANAGE CONFIGURATION - APPEARANCE
Project: WSW37B
Component: Xfer - e4/UI
Priority: 1
Subject: TVT_PTB: "Theme" dropdown is in English on Preferences>General>Appearance
Article ID: 98
Originator: marquesc@br.ibm.com
Stop Ship: N
</cde:tctdetail>
Comment 47 CDE Administration CLA 2011-09-20 23:04:17 EDT
<response_by> Eric Ma at 2011.09.20.21.48.25 </response_by>
Fixed for CHS, thanks!
Comment 48 CDE Administration CLA 2011-09-21 02:44:18 EDT
<response_by> SeYeon Lee at 2011.09.21.01.24.58 </response_by>
Fixed for Korean.

Thanks,
Seyeon
Comment 49 CDE Administration CLA 2011-09-21 02:44:21 EDT
<cde:tctdetail>
Testcase: 033.001.440 - BASE41 MANAGE CONFIGURATION - APPEARANCE
Project: 
Component: Xfer - e4/UI
Priority: 1
Subject: TVT_PTB: "Theme" dropdown is in English on Preferences>General>Appearance
Article ID: 98
Originator: marquesc@br.ibm.com
Stop Ship: N
</cde:tctdetail>
Comment 50 Eric Moffatt CLA 2011-09-27 15:45:30 EDT
Remy, should we mark this one VERIFIED ?
Comment 51 CDE Administration CLA 2011-09-27 15:51:08 EDT
<cde:tctdetail>
Testcase: 033.001.440 - BASE41 MANAGE CONFIGURATION - APPEARANCE
Project: WSW37B
Component: Xfer - e4/UI
Priority: 1
Subject: TVT_PTB: "Theme" dropdown is in English on Preferences>General>Appearance
Article ID: 98
Originator: marquesc@br.ibm.com
Stop Ship: N
</cde:tctdetail>
Comment 52 Remy Suen CLA 2011-09-27 16:02:11 EDT
(In reply to comment #50)
> Remy, should we mark this one VERIFIED ?

We marked it as VERIFIED two weeks ago actually.
https://bugs.eclipse.org/bugs/show_activity.cgi?id=356860