Bugzilla – Full Text Bug Listing
| Summary: | PageDesignerEditor: URLDecoder: Illegal hex characters in escape (%) pattern | ||
|---|---|---|---|
| Product: | [WebTools] Java Server Faces | Reporter: | Carlin Rogers <carlin.rogers> |
| Component: | UI | Assignee: | JSF Project UI <jsf.ui-inbox> |
| Status: | NEW --- | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | ian.trimble |
| Version: | 3.3.1 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
*** Bug 356845 has been marked as a duplicate of this bug. *** Adding debugging comments from Marcelo Paternostro (thanks, Marcelo): Sharing what I find out, this problem happens when one tries to use the "Web Page Editor" to open a JSP file with <%= ... >. The code in 'org.eclipse.jst.pagedesigner.utils.ProjectResolver.getLocationByURI(String, String)' is blindly passing the value of the XML attribute (src in the user example) to URLDecoder which throws a 'IllegalArgumentException' if the value is not a good URL (like a string with %=). Interesting enough, 'getLocationByURI' is ignoring any "UnsupportedEncodingException". Remembering that I don't know much about the domain here, I'd say that the possible fixes are: - Massage the input to support <%= and everything that is valid as part of a URL in a JSP file - Also ignore 'IllegalArgumentExceptions' (or even Exception), if the uri doesn't really need to be decoded in 'getLocationByURI' |
This error was reported in a forum. When the user tried to use WPE to open a JSP file, they received this message. "Could not open the editor: URLDecoder: Illegal hex in escape (%) pattern - For Input String: " =". To reproduce, outside of the WPE, create a JSP file and add the following content. Refresh your workspace and try to open the JSP in WPE. <table cellpadding="0" cellspacing="0" style="width:100%; font-family:Franklin Gothic Book; font-size:10pt; font-weight:bold; margin-top: 0px";> <tr style="white-space:nowrap"> <td style="height: 62px" align="left"><a href="default.jsp"><img id="EFLogo" src="<%=EFLib.Pub.Logo %>" style="border-style:none;" alt="The right way for form processing" title="The right way for form processing"/></a></td> <td valign="bottom" align="center" style="height: 62px" nowrap="nowrap"> </td> <td align="right" style="height: 62px"><img src="<%=EFLib.Pub.HeaderRightImg %>" alt="The right way for form processing" title="The right way for form processing"/></td> </tr> </table> Where "EFLib.Pub.Logo is a public static variable. This causes an IllegalArgumentException in a call to URLDecoder from the page designer's ProjectResolver. The user cannot open the file in WPE! Here's the error and stack trace... Unable to create editor ID org.eclipse.jst.pagedesigner.PageDesignerEditor: URLDecoder: Illegal hex characters in escape (%) pattern - For input string: "=E" java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - For input string: "=E" at java.net.URLDecoder.decode(Unknown Source) at org.eclipse.jst.pagedesigner.utils.ProjectResolver.getLocationByURI(ProjectResolver.java:372) at org.eclipse.jst.pagedesigner.utils.ProjectResolver.getLocationByURI(ProjectResolver.java:259) at org.eclipse.jst.pagedesigner.utils.ImageResolver.getResolvedURL(ImageResolver.java:47) at org.eclipse.jst.pagedesigner.utils.ImageResolver.initializeImage(ImageResolver.java:61) at org.eclipse.jst.pagedesigner.figurehandler.ImgFigureHandler.initializeImage(ImgFigureHandler.java:38) at org.eclipse.jst.pagedesigner.figurehandler.ImgFigureHandler.initializeWidgetProvider(ImgFigureHandler.java:49) at org.eclipse.jst.pagedesigner.figurehandler.WidgetFigureHandler.updateFigure(WidgetFigureHandler.java:34) at org.eclipse.jst.pagedesigner.figurehandler.FigureFactory.updateDeepFigure(FigureFactory.java:129) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.refresh(ElementEditPart.java:315) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.refresh(ElementEditPart.java:264) at org.eclipse.gef.editparts.AbstractEditPart.addNotify(AbstractEditPart.java:253) at org.eclipse.gef.editparts.AbstractGraphicalEditPart.addNotify(AbstractGraphicalEditPart.java:223) at org.eclipse.jst.pagedesigner.parts.NodeEditPart.addNotify(NodeEditPart.java:104) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.addNotify(ElementEditPart.java:155) at org.eclipse.gef.editparts.AbstractEditPart.addChild(AbstractEditPart.java:212) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.refresh(ElementEditPart.java:339) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.refresh(ElementEditPart.java:264) at org.eclipse.gef.editparts.AbstractEditPart.addNotify(AbstractEditPart.java:253) at org.eclipse.gef.editparts.AbstractGraphicalEditPart.addNotify(AbstractGraphicalEditPart.java:223) at org.eclipse.jst.pagedesigner.parts.NodeEditPart.addNotify(NodeEditPart.java:104) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.addNotify(ElementEditPart.java:155) at org.eclipse.gef.editparts.AbstractEditPart.addChild(AbstractEditPart.java:212) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.refresh(ElementEditPart.java:339) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.refresh(ElementEditPart.java:264) at org.eclipse.gef.editparts.AbstractEditPart.addNotify(AbstractEditPart.java:253) at org.eclipse.gef.editparts.AbstractGraphicalEditPart.addNotify(AbstractGraphicalEditPart.java:223) at org.eclipse.jst.pagedesigner.parts.NodeEditPart.addNotify(NodeEditPart.java:104) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.addNotify(ElementEditPart.java:155) at org.eclipse.gef.editparts.AbstractEditPart.addChild(AbstractEditPart.java:212) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.refresh(ElementEditPart.java:339) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.refresh(ElementEditPart.java:264) at org.eclipse.gef.editparts.AbstractEditPart.addNotify(AbstractEditPart.java:253) at org.eclipse.gef.editparts.AbstractGraphicalEditPart.addNotify(AbstractGraphicalEditPart.java:223) at org.eclipse.jst.pagedesigner.parts.NodeEditPart.addNotify(NodeEditPart.java:104) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.addNotify(ElementEditPart.java:155) at org.eclipse.gef.editparts.AbstractEditPart.addChild(AbstractEditPart.java:212) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.refresh(ElementEditPart.java:339) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.refresh(ElementEditPart.java:264) at org.eclipse.gef.editparts.AbstractEditPart.addNotify(AbstractEditPart.java:253) at org.eclipse.gef.editparts.AbstractGraphicalEditPart.addNotify(AbstractGraphicalEditPart.java:223) at org.eclipse.jst.pagedesigner.parts.NodeEditPart.addNotify(NodeEditPart.java:104) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.addNotify(ElementEditPart.java:155) at org.eclipse.gef.editparts.AbstractEditPart.addChild(AbstractEditPart.java:212) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.refresh(ElementEditPart.java:339) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.refresh(ElementEditPart.java:264) at org.eclipse.gef.editparts.AbstractEditPart.addNotify(AbstractEditPart.java:253) at org.eclipse.gef.editparts.AbstractGraphicalEditPart.addNotify(AbstractGraphicalEditPart.java:223) at org.eclipse.jst.pagedesigner.parts.NodeEditPart.addNotify(NodeEditPart.java:104) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.addNotify(ElementEditPart.java:155) at org.eclipse.gef.editparts.AbstractEditPart.addChild(AbstractEditPart.java:212) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.refresh(ElementEditPart.java:339) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.refresh(ElementEditPart.java:264) at org.eclipse.gef.editparts.AbstractEditPart.addNotify(AbstractEditPart.java:253) at org.eclipse.gef.editparts.AbstractGraphicalEditPart.addNotify(AbstractGraphicalEditPart.java:223) at org.eclipse.jst.pagedesigner.parts.NodeEditPart.addNotify(NodeEditPart.java:104) at org.eclipse.jst.pagedesigner.parts.ElementEditPart.addNotify(ElementEditPart.java:155) at org.eclipse.gef.editparts.AbstractEditPart.addChild(AbstractEditPart.java:212) at org.eclipse.gef.editparts.AbstractEditPart.refreshChildren(AbstractEditPart.java:781) at org.eclipse.jst.pagedesigner.parts.DocumentEditPart.refreshChildren(DocumentEditPart.java:134) at org.eclipse.jst.pagedesigner.parts.DocumentEditPart.refreshChildren(DocumentEditPart.java:126) at org.eclipse.gef.editparts.AbstractEditPart.refresh(AbstractEditPart.java:726) at org.eclipse.gef.editparts.AbstractGraphicalEditPart.refresh(AbstractGraphicalEditPart.java:644) at org.eclipse.jst.pagedesigner.parts.DocumentEditPart.refresh(DocumentEditPart.java:114) at org.eclipse.gef.editparts.AbstractEditPart.addNotify(AbstractEditPart.java:253) at org.eclipse.gef.editparts.AbstractGraphicalEditPart.addNotify(AbstractGraphicalEditPart.java:223) at org.eclipse.jst.pagedesigner.parts.NodeEditPart.addNotify(NodeEditPart.java:104) at org.eclipse.gef.editparts.AbstractEditPart.addChild(AbstractEditPart.java:212) at org.eclipse.gef.editparts.SimpleRootEditPart.setContents(SimpleRootEditPart.java:105) at org.eclipse.gef.ui.parts.AbstractEditPartViewer.setContents(AbstractEditPartViewer.java:617) at org.eclipse.gef.ui.parts.AbstractEditPartViewer.setContents(AbstractEditPartViewer.java:626) at org.eclipse.jst.pagedesigner.editors.SimpleGraphicalEditor.setModel(SimpleGraphicalEditor.java:425) at org.eclipse.jst.pagedesigner.editors.HTMLEditor.connectDesignPage(HTMLEditor.java:364) at org.eclipse.jst.pagedesigner.editors.HTMLEditor.createPages(HTMLEditor.java:444) at org.eclipse.ui.part.MultiPageEditorPart.createPartControl(MultiPageEditorPart.java:348) at org.eclipse.ui.internal.EditorReference.createPartHelper(EditorReference.java:670) at org.eclipse.ui.internal.EditorReference.createPart(EditorReference.java:465) at org.eclipse.ui.internal.WorkbenchPartReference.getPart(WorkbenchPartReference.java:595) at org.eclipse.ui.internal.PartPane.setVisible(PartPane.java:313) at org.eclipse.ui.internal.presentations.PresentablePart.setVisible(PresentablePart.java:180) at org.eclipse.ui.internal.presentations.util.PresentablePartFolder.select(PresentablePartFolder.java:270) at org.eclipse.ui.internal.presentations.util.LeftToRightTabOrder.select(LeftToRightTabOrder.java:65) at org.eclipse.ui.internal.presentations.util.TabbedStackPresentation.selectPart(TabbedStackPresentation.java:473) at org.eclipse.ui.internal.PartStack.refreshPresentationSelection(PartStack.java:1245) at org.eclipse.ui.internal.PartStack.setSelection(PartStack.java:1198) at org.eclipse.ui.internal.PartStack.showPart(PartStack.java:1597) at org.eclipse.ui.internal.PartStack.add(PartStack.java:493) at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:103) at org.eclipse.ui.internal.PartStack.add(PartStack.java:479) at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:112) at org.eclipse.ui.internal.EditorSashContainer.addEditor(EditorSashContainer.java:63) at org.eclipse.ui.internal.EditorAreaHelper.addToLayout(EditorAreaHelper.java:225) at org.eclipse.ui.internal.EditorAreaHelper.addEditor(EditorAreaHelper.java:213) at org.eclipse.ui.internal.EditorManager.createEditorTab(EditorManager.java:808) at org.eclipse.ui.internal.EditorManager.openEditorFromDescriptor(EditorManager.java:707) at org.eclipse.ui.internal.EditorManager.openEditor(EditorManager.java:666) at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched(WorkbenchPage.java:2942) at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:2850) at org.eclipse.ui.internal.WorkbenchPage.access$11(WorkbenchPage.java:2842) at org.eclipse.ui.internal.WorkbenchPage$10.run(WorkbenchPage.java:2793) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70) at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2789) at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2773) at org.eclipse.ui.actions.OpenWithMenu.openEditor(OpenWithMenu.java:331) at org.eclipse.ui.actions.OpenWithMenu$2.handleEvent(OpenWithMenu.java:179) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660) at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494) at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577) at org.eclipse.equinox.launcher.Main.run(Main.java:1410)