Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356837

Summary:	[Property View] Whole model leaked when closing model due to some property-related controls/observers not being disposed.
Product:	[Modeling] Papyrus	Reporter:	Alain Le Guennec <alain.leguennec>
Component:	Core	Assignee:	Camille Letavernier <cletavernier>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	cletavernier, eclipse-bugzilla, yann.tanguy
Version:	0.8.1
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:
Bug Blocks:	366943

Description Alain Le Guennec

2011-09-06 12:43:40 EDT

If you open or create a Papyrus model, and display the property page for the root model element, and then close the model, the memory occupied by the model won't be released.
Using a memory analyzer (such as jvisualvm or Eclipse MAT), you can see that the model is indirectly held by a StringEditor control, which itself is held by the Eclipse/SWT Display.
It looks like the property-related controls/observers are not always released (because the DisplayEngine's dispose method itself is probably not always called).
More specifically, it looks like the control of a property page are released/disposed when the display engine refreshes the views/sections (old controls are then disposed, and new controls are created). Therefore, the last displayed controls are probably never disposed, causing the leak on exit.

Comment 1 Camille Letavernier

2011-09-14 05:07:41 EDT

Some memory leaks have been fixed :

r5466, 5470 (Branch 0.8.X)
Merged to the trunk in r5467, r5473

The model seems to be still present in memory, but the property view doesn't seem to be directly responsible for that anymore. Maybe some observables which are not correctly disposed.

Comment 2 Camille Letavernier

2012-06-21 09:53:09 EDT

There hasn't been any new memory leak related to the property view (At least none were reported) ; I'm closing the task.