Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356795

Summary: [Unit Test Failure][0.2/4.2][0.2/3.8] org.eclipse.emf.facet.widgets.nattable.tests.Bug344413Test.testBug344413
Product: z_Archived Reporter: Gregoire Dupe <gdupe>
Component: EMF-FacetAssignee: Gregoire Dupe <gdupe>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: nicolas.bros
Version: unspecifiedFlags: gdupe: indigo+
gdupe: juno+
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
patch gdupe: iplog+, gdupe: review+

Description Gregoire Dupe CLA 2011-09-06 07:27:33 EDT 
The test org.eclipse.emf.facet.widgets.nattable.tests.Bug344413Test.testBug344413 fails on the build:
 - https://hudson.eclipse.org/hudson/job/emffacet-nightly/416/
 - https://hudson.eclipse.org/hudson/job/emffacet-nightly-maintenance/11/

== trunk modifications ==

Modification 813 by nbros:
Bug 356564 - [Table Editor] customizations on attributes and references don't work
The file was modified	/trunk/plugins/org.eclipse.emf.facet.widgets.nattable/src/org/eclipse/emf/facet/widgets/nattable/internal/painter/CustomizedCellPainter.java
Modification 812 by nbros:
Bug 355953 - Unable to create view from model element
The file was added	/trunk/tests/org.eclipse.emf.facet.widgets.nattable.tests/resources/Bug355953.uml
The file was added	/trunk/tests/org.eclipse.emf.facet.widgets.nattable.tests/src/org/eclipse/emf/facet/widgets/nattable/tests/swtbot/Bug355953Test.java
The file was added	/trunk/tests/org.eclipse.emf.facet.widgets.nattable.tests/src/org/eclipse/emf/facet/widgets/nattable/tests/internal/TableTestUtils.java
The file was modified	/trunk/plugins/org.eclipse.emf.facet.widgets.nattable/src/org/eclipse/emf/facet/widgets/nattable/internal/NatTableWidget.java
The file was modified	/trunk/tests/org.eclipse.emf.facet.widgets.nattable.tests/src/org/eclipse/emf/facet/widgets/nattable/tests/AllUITests.java

== branch modifications ==
Modification 811 by nbros:
Bug 355953 - Unable to create view from model element
The file was added	/branches/0_1/tests/org.eclipse.emf.facet.widgets.nattable.tests/src/org/eclipse/emf/facet/widgets/nattable/tests/swtbot/Bug355953Test.java
The file was added	/branches/0_1/tests/org.eclipse.emf.facet.widgets.nattable.tests/resources/Bug355953.uml
The file was modified	/branches/0_1/tests/org.eclipse.emf.facet.widgets.nattable.tests/src/org/eclipse/emf/facet/widgets/nattable/tests/AllUITests.java
The file was added	/branches/0_1/tests/org.eclipse.emf.facet.widgets.nattable.tests/src/org/eclipse/emf/facet/widgets/nattable/tests/internal/TableTestUtils.java
The file was modified	/branches/0_1/plugins/org.eclipse.emf.facet.widgets.nattable/src/org/eclipse/emf/facet/widgets/nattable/internal/NatTableWidget.java
Modification 810 by nbros:
Bug 356564 - [Table Editor] customizations on attributes and references don't work
The file was modified	/branches/0_1/plugins/org.eclipse.emf.facet.widgets.nattable/src/org/eclipse/emf/facet/widgets/nattable/internal/painter/CustomizedCellPainter.java
Comment 1 Nicolas Bros CLA 2011-09-06 08:56:01 EDT 
Created attachment 202802 [details]
patch

Here is a patch that fixes the regression introduced by the fix for Bug 355953.
Comment 2 Gregoire Dupe CLA 2011-11-07 12:24:20 EST 
Comment on attachment 202802 [details]
patch

Only for the branch 0.1.

In the trunk a better patch is expected (without a return in the middle of the method.)
Comment 3 Gregoire Dupe CLA 2011-12-08 12:10:11 EST 
Comment on attachment 202802 [details]
patch

I've committed the patch on the branch 0_1.

Committed revision 1252.
Comment 4 Gregoire Dupe CLA 2011-12-08 14:17:30 EST 
I've committed a fix on the trunk. This fix is different from Nicolas' patch because it contains code refactorings.

Committed revision 1253.

Let's wait the next build.
Comment 6 Gregoire Dupe CLA 2011-12-26 07:44:40 EST 
Can be closed.