Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356791

Summary:	Commit viewer diff tab shows additional empty lines for Windows line endings
Product:	[Technology] EGit	Reporter:	Sascha Scholz <sascha.scholz>
Component:	UI	Assignee:	Kevin Sawicki <kevin>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	kevin, matthias.sohn, remy.suen
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Sascha Scholz

2011-09-06 06:04:39 EDT

If line endings are in Windows format (CRLF), the commit viewer shows additional empty lines in the diff tab.

Tested on Windows and Linux.

Comment 1 Kevin Sawicki

2011-09-19 21:17:58 EDT

Can you post a screenshot of this or a link to a commit that shows the behavior?

Comment 2 Sascha Scholz

2011-09-20 14:11:16 EDT

Example commit is 862a05dd760c9dc27d1231824ea00a8b5085caac from git://git.eclipse.org/gitroot/mylyn/org.eclipse.mylyn.reviews.git

Comment 3 Kevin Sawicki

2011-09-20 15:52:03 EDT

Great thanks, that made it very easy to debug, proposed fix pushed to: http://egit.eclipse.org/r/#change,4273

Comment 4 Matthias Sohn

2011-09-21 19:03:07 EDT

merged as 741a4fd2fc001e639a16b7e68773eb4154e34cc8