Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356765

Summary:	Egit should respect preexisting key bindings in JDT refactoring set ALT+CMD+M ALT+CMD+I
Product:	[Technology] EGit	Reporter:	maarten meijer <mjmeijer>
Component:	UI	Assignee:	Project Inbox <egit.ui-inbox>
Status:	CLOSED DUPLICATE	QA Contact:
Severity:	normal
Priority:	P3	CC:	matthias.sohn
Version:	1.0
Target Milestone:	---
Hardware:	Macintosh
OS:	Mac OS X
Whiteboard:

Description maarten meijer

2011-09-06 03:35:19 EDT

What steps will reproduce the problem?
1. startup eclipse with EGit and JDT present 
2. key combination no longer works
3. JDT used it first


-- Error Details --
Date: Tue Sep 06 09:26:43 CEST 2011
Message: A conflict occurred for ALT+COMMAND+I:
Binding(ALT+COMMAND+I,
	ParameterizedCommand(Command(org.eclipse.egit.ui.team.Ignore,Ignore,
		,
		Category(org.eclipse.egit.ui.commandCategory,Git,null,true),
		org.eclipse.egit.ui.internal.actions.IgnoreActionHandler,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,,system)
Binding(ALT+COMMAND+I,
	ParameterizedCommand(Command(org.eclipse.jdt.ui.edit.text.java.inline,Inline,
		Inline a constant, local variable or method,
		Category(org.eclipse.jdt.ui.category.refactoring,Refactor - Java,Java Refactoring Actions,true),
		,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,cocoa,system)
	
AND

A conflict occurred for ALT+COMMAND+M:
Binding(ALT+COMMAND+M,
	ParameterizedCommand(Command(org.eclipse.egit.ui.team.Merge,Merge,
		,
		Category(org.eclipse.egit.ui.commandCategory,Git,null,true),
		,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,,system)
Binding(ALT+COMMAND+M,
	ParameterizedCommand(Command(org.eclipse.jdt.ui.edit.text.java.extract.method,Extract Method,
		Extract a set of statements or an expression into a new method and use the new method,
		Category(org.eclipse.jdt.ui.category.refactoring,Refactor - Java,Java Refactoring Actions,true),
		,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,cocoa,system)
Severity: Warning
Product: Eclipse 1.4.0.20110609-1120 (org.eclipse.epp.package.rcp.product)
Plugin: org.eclipse.jface
Session Data:
eclipse.buildId=I20110613-1736
java.version=1.6.0_26
java.vendor=Apple Inc.
BootLoader constants: OS=macosx, ARCH=x86_64, WS=cocoa, NL=en_US
Framework arguments:  -product org.eclipse.epp.package.rcp.product -keyring /Users/maarten/.eclipse_keyring -showlocation
Command-line arguments:  -os macosx -ws cocoa -arch x86_64 -product org.eclipse.epp.package.rcp.product -keyring /Users/maarten/.eclipse_keyring -showlocation

Comment 1 maarten meijer

2011-09-06 03:36:21 EDT

Also ALT+CMD+C

A conflict occurred for ALT+COMMAND+C:
Binding(ALT+COMMAND+C,
	ParameterizedCommand(Command(org.eclipse.egit.ui.team.Commit,Commit,
		,
		Category(org.eclipse.egit.ui.commandCategory,Git,null,true),
		,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,,system)
Binding(ALT+COMMAND+C,
	ParameterizedCommand(Command(org.eclipse.jdt.ui.edit.text.java.modify.method.parameters,Change Method Signature,
		Change method signature includes parameter names and parameter order,
		Category(org.eclipse.jdt.ui.category.refactoring,Refactor - Java,Java Refactoring Actions,true),
		,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,cocoa,system)

Comment 2 Matthias Sohn

2011-09-06 04:21:57 EDT


*** This bug has been marked as a duplicate of bug 321739 ***