Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356674

Summary:	Improve extensibility of SapphireWizard
Product:	z_Archived	Reporter:	Nepomuk Seiler <nepomuk.seiler>
Component:	Sapphire	Assignee:	Konstantin Komissarchik <konstantin>
Status:	CLOSED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	konstantin, ling.hao
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Nepomuk Seiler

2011-09-04 08:21:01 EDT

Build Identifier: 

Extending SapphireWizard is hard, because addPages and perfomFinish are declared as final. I refer to this forum thread where this problem is discussed in detail: 
http://www.eclipse.org/forums/index.php/m/722086/

Reproducible: Always

Comment 1 Konstantin Komissarchik

2011-09-04 11:33:32 EDT

I am fine with making addPages method non-final, but making performFinish non-final would not be safe due to complex threading/locking issues that would arise from overriding that method directly. Instead, I will create an overridable protected variant of performFinish that will be called from the body of the main performFinish.

Comment 2 Konstantin Komissarchik

2011-09-04 11:37:26 EDT

Enhancement implemented in 0.3.1 and 0.4 streams. Please verify.

Comment 3 Ling Hao

2011-09-28 19:50:35 EDT

Verify addPages is non-final and a protected performPostFinish method that the user can override.