Bugzilla – Full Text Bug Listing
| Summary: | Version errors in 3.3.1 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] Java Server Faces | Reporter: | Raghunathan Srinivasan <raghunathan.srinivasan> | ||||||||
| Component: | JSF Tools | Assignee: | Raghunathan Srinivasan <raghunathan.srinivasan> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | blocker | ||||||||||
| Priority: | P3 | CC: | cbridgha, ccc, david_williams, neil.hauge | ||||||||
| Version: | 3.3 | Flags: | david_williams:
pmc_approved+
raghunathan.srinivasan: pmc_approved? (naci.dai) raghunathan.srinivasan: pmc_approved? (deboer) neil.hauge: pmc_approved+ raghunathan.srinivasan: pmc_approved? (kaloyan) raghunathan.srinivasan: pmc_approved? (cbridgha) raghunathan.srinivasan: review+ |
||||||||
| Target Milestone: | 3.3.1 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Whiteboard: | PMC_approved | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 202712 [details]
Fix version error
I am releasing the changes to 3.3.1 in case we decide we need a build without version errors to contribute to the Indigo SR1 repository. Raghu, in each of these, the version was incremented, but the license was removed, so now we have license consistency errors in each of these features. Can the removal of the license be reverted? I am raising this to blocking, since these issues must be addressed before Indigo SR1. I have made no changes that should affect the license. The last change to the license were tracked in Bug 337656. Any idea where should I look to see the 'difference'? I see the difference in feature.xml between o.e.jsf.feature and o.e.jst.webpageeditro.feature. I will make the change and release. Thanks Created attachment 202774 [details]
Patch to fix license differences
Released the changes to fix license issue as reported in http://build.eclipse.org/webtools/committers/wtp-R3.3.1-M/20110903234441/M-3.3.1-20110903234441/testResults/licenseConsistency.html (In reply to comment #3) > Raghu, in each of these, the version was incremented, but the license was > removed, so now we have license consistency errors in each of these features. > Can the removal of the license be reverted? > > I am raising this to blocking, since these issues must be addressed before > Indigo SR1. Per Bug 337656 ,license files were removed on favor of the 'PDE Build technique' to reference the license file. Hi Raghu, I initially missed the second patch renamed, and effectively deleted the org.eclipse.jsf_sdk.feature. Was this intentional? <feature - id="org.eclipse.jsf_sdk.feature" + id="org.eclipse.jsf.feature" To make things more interesting, in v 1.12 of org.eclipse.jsf_jdk.feature/feature.xml, the id was changed back to org.eclipse.jsf_jdk.feature ... but the other changes were not reverted. Therefore, a feature that all of the aggregation relies on, org.eclipse.jsf.feature, is no longer part of WTP 3.3.1 builds. No intention of removing the SDK feature. Reviewing Created attachment 202846 [details]
Fix regression in the SDK feature
Requesting PMC approval to fix the regression introduced in the attempt to fix the license issue. Released to 3.3.1. |
org.eclipse.jsf.feature 3.3.0.v201103022146-7E7IDUF9JgLWUM6WBSgXp (current) 3.3.0.v201103022146-7E7IBvF9JgLWUM3U8Shak (reference) org.eclipse.jsf_sdk.feature 3.3.0.v201103022146-775-84JAMHXLCOlPccOGmLmx25AKhMXVN7XCThYq (current) 3.3.0.v201103022146-775-84JAMFyLCOlPccODkImwY0AKhMXVN4V9Tibl (reference) org.eclipse.jst.webpageeditor.feature 2.3.4.v201105111126-46AA9oB5875L5K4I77 (current) 2.3.4.v201105111126-468b9oB5875G5M6D4A (reference) org.eclipse.jst.webpageeditor_sdk.feature 2.3.4.v201105111126-557781BDEDrJ9CB9QEMBRKKApC6986M6L5J88 (current) 2.3.4.v201105111126-557781BBfDrJ9CB9LEODMFoApC6986H6N7E5B (reference)