Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356663

Summary: Mwe2Runner.run forgets what it s doing
Product: [Modeling] EMFT Reporter: Ed Willink <ed>
Component: MWEAssignee: Project Inbox <emft-mwe-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: sven.efftinge
Version: unspecifiedFlags: sven.efftinge: juno+
Target Milestone: M6   
Hardware: PC   
OS: Windows Vista   
Whiteboard:

Description Ed Willink CLA 2011-09-03 07:17:57 EDT
Mwe2Runner.run (line 65) is

	run(((Module) eObject).getCanonicalName(), params);

This converts the known Module into a String, so that at line 78

	Module module = findModule(moduleName);

has to do a search to discover it. This is expensive, since every MWE2 in at least the project has to be loaded and parsed to rediscover what was already known.

Partial stack trace below:

Mwe2Runner.findModule(String) line: 119	
Mwe2Runner.run(String, Map<String,String>, IWorkflowContext) line: 77	
Mwe2Runner.run(String, Map<String,String>) line: 73	
Mwe2Runner.run(URI, Map<String,String>, IWorkflowContext) line: 64	
Mwe2Runner.run(URI, Map<String,String>) line: 55	
Mwe2Launcher.run(String[]) line: 74	
Mwe2Launcher.main(String[]) line: 35
Comment 1 Sven Efftinge CLA 2012-03-07 10:54:21 EST
pushed to master